Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6898: Replace atoi() with strtoul() #6936

Merged
merged 1 commit into from Oct 11, 2018
Merged

Fix #6898: Replace atoi() with strtoul() #6936

merged 1 commit into from Oct 11, 2018

Conversation

MiguelHorta
Copy link
Contributor

Normalize type and parsing of generation_seed across all files
Add static_assert() to ensure correct type

LordAro
LordAro previously approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - you might want to check your git config, github seems to think the commit has been authored/committed by 2 different people, neither of which is linked to your GH account

@MiguelHorta
Fix OpenTTD#6898: Replace atoi() with strtoul()
a0f1629 
Normalize type and parsing of generation_seed across all files
Add assert_compile() to ensure correct type
@MiguelHorta
Copy link
Contributor Author

Thanks for the head-ups. Indeed, my git configuration was wrong.
Unfortunately, it seems I invalidated your review while trying to fix, sorry about that :|

@orudge orudge merged commit e00908f into OpenTTD:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MiguelHorta @LordAro @orudge