Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.escapism: 0.0.1 -> 1.0.0 move to python-modules #48165

Merged
merged 1 commit into from Oct 11, 2018
Merged

pythonPackages.escapism: 0.0.1 -> 1.0.0 move to python-modules #48165

merged 1 commit into from Oct 11, 2018

Conversation

costrouc
Copy link
Member

Things done

pythonPackages.escapism: 0.0.1 -> 1.0.0 move to python-modules

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner October 10, 2018 17:18
@Mic92 Mic92 merged commit af35bf9 into NixOS:master Oct 11, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 11, 2018

Thanks!

@costrouc
Copy link
Member Author

costrouc commented Oct 11, 2018 •
edited

@Mic92 I just wanted to ask a question. You merged my pull request without checking that it builds? I have submitted ~20 or so PRs to nixpkgs. Did you just trust me that it built under sandbox for me or did you test the PR locally? (Only asking because it makes me nervous that a package upgrade would be accepted without double checking - even if I do trust my PR). 😄

@FRidh
Copy link
Member

FRidh commented Oct 11, 2018

Looking at the amount of rebuilds you can't break much so often its not worth the scrutiny then :-)
Considering the amount of contributions I do recommend adding yourself to the ofborg list so ofborg will build your PR's
https://github.com/NixOS/ofborg/blob/released/config.known-users.json

@costrouc costrouc mentioned this pull request Oct 11, 2018
Merged
@Mic92
Copy link
Member

Mic92 commented Oct 12, 2018 •
edited

@costrouc I use https://github.com/Mic92/nix-review for the majority of pull requests. I usually do this before looking at what contributor has tested so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @Mic92 @FRidh @GrahamcOfBorg