Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dopy: refactor move to python-modules #48164

Merged
merged 1 commit into from Oct 15, 2018
Merged

pythonPackages.dopy: refactor move to python-modules #48164

merged 1 commit into from Oct 15, 2018

Conversation

costrouc
Copy link
Member

Things done

pythonPackages.dopy: refactor move to python-modules

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner October 10, 2018 17:06
@costrouc costrouc force-pushed the costrouc/python-dopy-refactor branch from ea909ab to e47a7f8 Compare October 14, 2018 13:07
@costrouc
Copy link
Member Author

Fixed with corrections. Ready for merge.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.dopy python3Packages.dopy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.dopy, python3Packages.dopy

Partial log (click to expand)

running build_ext
/nix/store/sav6zmqg1azzg95j88ypr74bl8xn5a3v-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/dist.py:398: UserWarning: Normalizing '0.3.7a' to '0.3.7a0'
  normalized_version,

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/fr3s4azxv2qk4wwhipfnncs7khi5bwna-python2.7-dopy-2016-01-04
/nix/store/2nrd689gi2j1bxr4g46h7rhhz70mb0n5-python3.6-dopy-2016-01-04

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.dopy, python3Packages.dopy

Partial log (click to expand)

running build_ext
/nix/store/rd79ml4yd7a4r9hl7jwnxgqiwpym7i86-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/dist.py:398: UserWarning: Normalizing '0.3.7a' to '0.3.7a0'
  normalized_version,

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/46lxdjcbrbivvz9s1xc99xd8isvqsbj4-python2.7-dopy-2016-01-04
/nix/store/w29fygq96phx2a86klbfg3z6fl7h396b-python3.6-dopy-2016-01-04

@costrouc
Copy link
Member Author

Ready for merge

@Mic92 Mic92 merged commit 8099538 into NixOS:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @GrahamcOfBorg @FRidh @Mic92