Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.filterpy: init at 1.4.5 #48192

Merged
merged 1 commit into from Oct 11, 2018
Merged

pythonPackages.filterpy: init at 1.4.5 #48192

merged 1 commit into from Oct 11, 2018

Conversation

costrouc
Copy link
Member

Things done

pythonPackages.filterpy: init at 1.4.5

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner October 11, 2018 01:45
@FRidh
Copy link
Member

FRidh commented Oct 11, 2018

@GrahamcOfBorg build python3Packages.filterpy

@infinisil
Copy link
Member

Oh actually, this seems to even be the only test: https://github.com/rlabbe/filterpy/tree/master/filterpy/common/tests

So you might as well just do doCheck = false

@costrouc
Copy link
Member Author

@infinisil there are actually about 50 tests if I remember correctly. The tests are within each folder for example https://github.com/rlabbe/filterpy/tree/master/filterpy/kalman/tests.

@infinisil
Copy link
Member

Ah I see

@GrahamcOfBorg build python2Packages.filterpy python3Packages.filterpy

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.filterpy, python3Packages.filterpy

Partial log (click to expand)

filterpy/stats/tests/test_stats.py ....                                  [100%]

========================== 65 passed in 61.38 seconds ==========================
pytestcachePhase
filterpy/stats/tests/test_stats.py ....                                  [100%]

========================== 65 passed in 63.75 seconds ==========================
pytestcachePhase
/nix/store/5jc9r63ffih2v9z10fah3lp9vqj5zlmg-python2.7-filterpy-1.4.5
/nix/store/769ydgdkwym142pf8r1d60dipdzzbpxn-python3.6-filterpy-1.4.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.filterpy, python3Packages.filterpy

Partial log (click to expand)

filterpy/kalman/tests/test_sqrtkf.py .                                   [ 63%]
filterpy/kalman/tests/test_ukf.py .............                          [ 83%]
filterpy/leastsq/tests/test_lsq.py ......                                [ 92%]
filterpy/memory/tests/test_fading_memory.py .                            [ 93%]
filterpy/stats/tests/test_stats.py ....                                  [100%]

========================== 65 passed in 52.61 seconds ==========================
pytestcachePhase
/nix/store/5yf76milfxfp55qiixz8r0ydlgjysdbm-python2.7-filterpy-1.4.5
/nix/store/vkicm6305542j4jlid0v4f4cpmlqqjax-python3.6-filterpy-1.4.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.filterpy, python3Packages.filterpy

Partial log (click to expand)

filterpy/stats/tests/test_stats.py ....                                  [100%]

========================= 65 passed in 220.60 seconds ==========================
pytestcachePhase
filterpy/stats/tests/test_stats.py ....                                  [100%]

========================= 65 passed in 223.01 seconds ==========================
pytestcachePhase
/nix/store/33vf0lsi0dg9fxgcwi5k8hp8bdzy2pi7-python2.7-filterpy-1.4.5
/nix/store/n533m2xy0hazf8nf0p98jc69g5bsc0lw-python3.6-filterpy-1.4.5

@infinisil infinisil merged commit c166d05 into NixOS:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @FRidh @infinisil @GrahamcOfBorg