Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt-ergo: 1.30->2.2.0, ocplib-simplex: 0.3->0.4 #48175

Closed
wants to merge 1 commit into from

Conversation

cocreature
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Oct 11, 2018

The meta.license field of alt-ergo claims CÉCILL-C. Is that true?

@cocreature
Copy link
Contributor Author

@vbgl Good catch! I missed that they updated the license. I’ve now changed it to properly reflect the current license.

@vbgl
Copy link
Contributor

vbgl commented Oct 12, 2018

That’s a bit annoying to “update” to a non-free version. Moreover, they did mention that there should be a free version of Alt-Ergo 2 (https://lists.gforge.inria.fr/pipermail/why3-club/2017-November/001611.html).

@cocreature
Copy link
Contributor Author

So how do we move forward here? That comment is about a year old, alt-ergo 2.0 has been released almost a year ago, alt-ergo 2.2 has been released in April and afaik there is still no free version. I’m not really fond of sticking with an old version forever in the hopes that at some point we might be able to upgrade it. I suppose another option would be to keep both 1.3 and 2.0 around but I doubt that alt-ergo is sufficiently popular to justify that.

@vbgl
Copy link
Contributor

vbgl commented Oct 13, 2018

I’m convinced. Let’s acknowledge that Alt-Ergo is no longer free.

Can you please remove the overriding of ocamlPackages when calling the alt-ergo package in all-packages.nix? I think num is also missing from its build-inputs.

Also, what is the purpose of the patch? It seems enough to set installFlags = "LIBDIR=$(OCAMLFIND_DESTDIR)";.

@cocreature
Copy link
Contributor Author

I’ve removed the patch (thanks for pointing this out, I wasn’t aware that you could override variables like that), removed the override and added num to the build-inputs.

@vbgl
Copy link
Contributor

vbgl commented Oct 13, 2018

@GrahamcOfBorg build alt-ergo

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: alt-ergo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: alt-ergo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: alt-ergo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@vbgl
Copy link
Contributor

vbgl commented Oct 13, 2018

Merged as 6738033.

@vbgl vbgl closed this Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants