Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c45a6fa041d7
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e7334bc6e943
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 10, 2018

  1. CONTRIBUTING.md: Clarify clarification on periods 

    Commit 9428c28 added a note in
`CONTRIBUTING.md` saying that, "For consistency, there should not be a
period at the end of the commit message."

I believe it would be more correct (with respect to consistency) to
say that there should not be a full stop/period at the end of the
commit message's *summary line* (the first line of the commit message)
(indeed, the example commit message just above this note clearly does
use full stops outside of its summary line), and this patch changes
`CONTRIBUTING.md` accordingly.
    @8573
    8573 committed Oct 10, 2018
    1 Configuration menu
    Copy the full SHA
    e74c766 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #48179 from 8573/8573/fix/CONTRIBUTING.md/clarify-… 

    …clarification-on-full-stops/1

CONTRIBUTING.md: Clarify clarification on periods
    @Mic92
    Mic92 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    e7334bc View commit details
    Browse the repository at this point in the history