Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

znc: add option to enable unicode support #48678

Merged
merged 1 commit into from Oct 18, 2018
Merged

znc: add option to enable unicode support #48678

merged 1 commit into from Oct 18, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 18, 2018 •
edited

Motivation for this change

Add option to enable unicode support

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil reviewed Oct 18, 2018
View reviewed changes
pkgs/applications/networking/znc/default.nix Outdated
@@ -3,6 +3,7 @@
, withPython ? false, python3
, withTcl ? false, tcl
, withCyrus ? true, cyrus_sasl
, withUnicode ? false, icu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be enabled by default.

Check the closure size difference with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@infinisil
Copy link
Member

@GrahamcOfBorg build znc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: znc

Partial log (click to expand)

shrinking /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/lib/znc/cert.so
shrinking /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/lib/znc/simple_away.so
shrinking /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/lib/znc/route_replies.so
gzipping man pages under /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/lib  /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/bin
patching script interpreter paths in /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1
/nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1/bin/znc-buildmod: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1...
/nix/store/ckjnxd5hx03id9j6f7hf2sdkmk690ysp-znc-1.7.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: znc

Partial log (click to expand)

shrinking /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/lib/znc/adminlog.so
shrinking /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/lib/znc/admindebug.so
shrinking /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/bin/znc
gzipping man pages under /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/lib  /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/bin
patching script interpreter paths in /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1
/nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1/bin/znc-buildmod: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1...
/nix/store/j06ikb104dccsg8ik27yw64vix16af00-znc-1.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: znc

Partial log (click to expand)


 If you need help with using ZNC, please visit our wiki at:
   https://znc.in
post-installation fixup
gzipping man pages under /nix/store/rf280kwnxgj11bj1jm6mvdcqzn7cr85f-znc-1.7.1/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rf280kwnxgj11bj1jm6mvdcqzn7cr85f-znc-1.7.1/lib  /nix/store/rf280kwnxgj11bj1jm6mvdcqzn7cr85f-znc-1.7.1/bin
patching script interpreter paths in /nix/store/rf280kwnxgj11bj1jm6mvdcqzn7cr85f-znc-1.7.1
/nix/store/rf280kwnxgj11bj1jm6mvdcqzn7cr85f-znc-1.7.1/bin/znc-buildmod: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/rf280kwnxgj11bj1jm6mvdcqzn7cr85f-znc-1.7.1

@infinisil infinisil merged commit 810da21 into NixOS:master Oct 18, 2018
@Izorkin Izorkin deleted the znc branch October 18, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @infinisil @GrahamcOfBorg