Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

w3m: 20161120 -> 20180125 #48672

Merged
merged 1 commit into from Nov 3, 2018
Merged

w3m: 20161120 -> 20180125 #48672

merged 1 commit into from Nov 3, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 18, 2018

https://raw.githubusercontent.com/tats/w3m/v0.5.3+git20180125/NEWS

Include some CVE fixes it would appear.

The patches still apply but not sure if are still desired/needed,
in question because folks over at void seem to have dropped across
updates leading up to and including this version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Probably should be merged along with imlib2 update since this depends
on imlib2 and through w3m both have similar rebuild lists I think.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: w3m

Partial log (click to expand)

shrinking /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/libexec/w3m/w3mimgdisplay
shrinking /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mhelperpanel
shrinking /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mbookmark
shrinking /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/bin/w3m
gzipping man pages under /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/libexec  /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/bin
patching script interpreter paths in /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125
/nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mdict.cgi: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/xrprlhjjcyzlxcwfass5xb5rjm968gjw-w3m-0.5.3+git20180125...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: w3m

Partial log (click to expand)

shrinking /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mbookmark
shrinking /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mhelperpanel
shrinking /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/libexec/w3m/inflate
shrinking /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/bin/w3m
gzipping man pages under /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/libexec  /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/bin
patching script interpreter paths in /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125
/nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mdict.cgi: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/f666r26m3ihfak7jr9pa2zz3vm6qxspx-w3m-0.5.3+git20180125...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: w3m

Partial log (click to expand)

  : ; \
fi
make[1]: Leaving directory '/private/tmp/nix-build-w3m-0.5.3+git20180125.drv-0/source/po'
post-installation fixup
gzipping man pages under /nix/store/q73zwfxzfnak7r2l8d0pkqjn6md9zcyv-w3m-0.5.3+git20180125/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q73zwfxzfnak7r2l8d0pkqjn6md9zcyv-w3m-0.5.3+git20180125/libexec  /nix/store/q73zwfxzfnak7r2l8d0pkqjn6md9zcyv-w3m-0.5.3+git20180125/bin
patching script interpreter paths in /nix/store/q73zwfxzfnak7r2l8d0pkqjn6md9zcyv-w3m-0.5.3+git20180125
/nix/store/q73zwfxzfnak7r2l8d0pkqjn6md9zcyv-w3m-0.5.3+git20180125/libexec/w3m/cgi-bin/w3mdict.cgi: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/q73zwfxzfnak7r2l8d0pkqjn6md9zcyv-w3m-0.5.3+git20180125

@Mic92
Copy link
Member

Mic92 commented Oct 18, 2018

I was just today collecting crash traces from w3m. Now I have one more :)

@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2018

Any thoughts on this? Okay to merge?

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2018 •
edited

I tested it quickly with

$ nix-review pr -p w3m 48672

and surfed a bit on wikipedia. Looks good to me.

@dtzWill dtzWill merged commit 86cee97 into NixOS:staging Nov 3, 2018
@dtzWill dtzWill deleted the update/w3m-2018 branch November 3, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @Mic92 @roberth