Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: make communication section a markdown headline #48669

Closed
wants to merge 1 commit into from
Closed

README.md: make communication section a markdown headline #48669

wants to merge 1 commit into from

Conversation

mhusnulwardi
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Oct 18, 2018
View reviewed changes
README.md
@@ -35,7 +35,7 @@ For pull-requests, please rebase onto nixpkgs `master`.
* [Tests for unstable/master](https://hydra.nixos.org/job/nixos/trunk-combined/tested#tabs-constituents)
* [Tests for 18.09 release](https://hydra.nixos.org/job/nixos/release-18.09/tested#tabs-constituents)

Communication:
# Communication:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the title a bit bold. I think ## or even ### looks better.

@Ma27
Copy link
Member

Ma27 commented Oct 18, 2018

and can you please improve the descriptiveness of your commit message? "Update X" can mean a lot even if it's just about the readme.

@Mic92 Mic92 changed the title README.md README.md: make communication section a markdown headline Oct 18, 2018
@infinisil
Copy link
Member

Closing for same reasons as described in #48854 (comment):

  • Not a useful change, doesn't really add anything
  • Not bothered to check the contribution guidelines and check the boxes

@infinisil infinisil closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
2.status: invalid 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mhusnulwardi @Ma27 @infinisil @Mic92 @lheckemann @GrahamcOfBorg @Janik-Haag