New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvidia_x11: 390.87 -> 410.66 #48661
nvidia_x11: 390.87 -> 410.66 #48661
Conversation
Yeah that sounds like a good idea |
Never really did this in my PR since I assumed most people who would use it probably lie on amd64, though the assignment in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/hardware/video/nvidia.nix#L14 |
I understand that v410 is now considered stable, so I would do 2 things:
In this way we keep a working default for both platforms |
9ad43bb
to
9f86bcd
Compare
I have updated the commit: Some packages reference the default So |
9f86bcd
to
52352ab
Compare
There is currently no beta active
@cpages I have set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It might be nice to have some people with different graphics cards test this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infinisil I don't think this new version even drops support for any older card, so for me this can be pushed
The update works just fine with my 970. |
This merge broke my system. I have a 64-bit system with an Nvidia GeForce GTX 560 Ti graphics card, which is only supported in the now legacy 390.x series. According to the changes, because I have a 64-bit system, the 410.x series would be used instead of the 390.x. However, there are no legacy_390 options to choose from, so I am stuck without a proper driver for the moment. Please see #49679 |
Can we revert this until the 390.x series is packaged separately? Being stuck on an old revision of nixos-unstable is no fun. :( |
Hm, that PR hasn't even been reviewed yet, it seems like it getting merged and then making its way to nixos-unstable might be a while off. vvvvvvv ah cool thanks for clarifying |
With #51294, every time there needs to be a legacy package, the way most users use it would be through |
Motivation for this change
Nvidia stable branch driver was updated to 410.66. With the work from #45030 this change is simple.
Note: Nvidia dropped support for x86. There are legacy versions present, but the last driver for x86 is 390.87. So maybe I should add it as a separate version like the legacy versions below?
/cc @infinisil, @eadwu, @tenten8401
see also #44461
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)