Avoid capturing platform-specific font data #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw3583
approved these changes
Oct 18, 2018
Co-Authored-By: kvark <kvarkus@gmail.com>
|
thanks! |
|
📌 Commit fef45d5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2018
Avoid capturing platform-specific font data This PR avoids the capturing to carry or load the platform-specific font instance data. It's less ideal for the case where the replay is done on the same platform, but makes captures more robust and portable overall. Ideally, we'd want to still save it but ignore on other platforms, but this would be less trivial (TODO). r? anyone <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3215) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids the capturing to carry or load the platform-specific font instance data. It's less ideal for the case where the replay is done on the same platform, but makes captures more robust and portable overall. Ideally, we'd want to still save it but ignore on other platforms, but this would be less trivial (TODO).
r? anyone
This change is