cozy-audiobooks: init at 0.6.3 #47631

makefu · 2018-10-01T22:21:40Z

Motivation for this change

add the cozy-audiobook package

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-10-02T00:14:12Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cozy-audiobooks

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T00:15:06Z

Success on aarch64-linux (full log)

Attempted: cozy-audiobooks

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3/bin/cozy-audiobooks
Wrapping program /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3/bin/com.github.geigi.cozy
Wrapping program /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3/bin/.com.github.geigi.cozy-wrapped
shrinking RPATHs of ELF executables and libraries in /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3/lib  /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3/bin
patching script interpreter paths in /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3
checking for references to /build in /nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3...
/nix/store/3aqw5bil2h5y2pga8mhjp7rqid374lph-cozy-0.6.3

GrahamcOfBorg · 2018-10-02T00:15:12Z

Success on x86_64-linux (full log)

Attempted: cozy-audiobooks

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3/bin/.com.github.geigi.cozy-wrapped
Wrapping program /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3/bin/com.github.geigi.cozy
Wrapping program /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3/bin/cozy-audiobooks
shrinking RPATHs of ELF executables and libraries in /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3/lib  /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3/bin
patching script interpreter paths in /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3
checking for references to /build in /nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3...
/nix/store/7wb35lh0nyzyl1j0fdz6fr137ada3rn0-cozy-0.6.3

worldofpeace · 2018-10-10T03:38:17Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+, gnome3
+}:
+
+stdenv.mkDerivation rec {


buildPythonApplication seems to be better for this. See gnome-music.

i don't see how this would work as there is no setup.py

buildPythonApplication takes a parameter format which should be set to other in this case

nixpkgs/pkgs/desktops/gnome-3/apps/gnome-music/default.nix

Line 11 in 29d0eec

format = "other";

This defaults to "setuptools" which is for when there's a setup.py

okay, i changed that. who knew!

worldofpeace · 2018-10-10T03:39:23Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+, appstream-glib
+, desktop-file-utils
+, gtk3
+, glib


gtk3 propagates glib so can drop glib.

seems to work, however i am not sure how anyone would know arcane wisdom this when packaging if not explicitly being told.

Yeah, we're trying to get some docs 🤣

worldofpeace · 2018-10-10T03:40:51Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+  postInstall = ''
+      wrapProgram $out/bin/com.github.geigi.cozy \
+      --prefix PYTHONPATH : "$PYTHONPATH:$(toPythonPath $out)"
+      ln -s $out/bin/com.github.geigi.cozy $out/bin/cozy-audiobooks


The author intended for the executable to be rddn'd and I think this won't match the Exec in the .desktop file either.

you mean renamed to cozy? i can do that

i just checked, com.github.geigi.cozy is inside the .desktop file, i still think symlinking it to something you can actually find in your path is a good idea.

worldofpeace · 2018-10-10T03:42:20Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+    cairo
+    gettext
+    gnome3.defaultIconTheme
+    gnome3.gsettings-desktop-schemas


gnome3.gsettings-desktop-schemas is also propagated by gtk3.

pkgs/applications/audio/cozy-audiobooks/default.nix

worldofpeace · 2018-10-10T03:47:28Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+       A modern audio book player for Linux using GTK+ 3
+    '';
+    maintainers = [ maintainers.makefu ];
+    license = licenses.mit;


I think this should be mit and gpl3 because of this and this

worldofpeace · 2018-10-10T03:49:19Z

pkgs/top-level/all-packages.nix

@@ -653,6 +653,8 @@ with pkgs;

  chkcrontab = callPackage ../tools/admin/chkcrontab { };

+  cozy-audiobooks = callPackage ../applications/audio/cozy-audiobooks { };


This should be just cozy.

makefu · 2018-10-10T10:05:05Z

@worldofpeace thanks for the review!

worldofpeace · 2018-10-10T16:18:38Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+    gst-plugins-good
+    gst-plugins-ugly
+    gst-plugins-base
+  ]) ++ (with python3Packages; [


If you use buildPythonApplication these buildInputs

++ (with python3Packages; [...

should be propagatedBuildInputs.

worldofpeace · 2018-10-11T05:32:12Z

Make sure to also change the directory from pkgs/applications/audio/cozy-audiobooks -> pkgs/applications/audio/cozy.

Also the attribute name in the commit message.

worldofpeace · 2018-10-11T06:03:39Z

pkgs/applications/audio/cozy-audiobooks/default.nix

+  ]);
+
+  propagatedBuildInputs = with python3Packages; [
+    python


You can drop this python.

makefu · 2018-10-11T13:01:33Z

Make sure to also change the directory from pkgs/applications/audio/cozy-audiobooks -> pkgs/applications/audio/cozy.

Also the attribute name in the commit message.

I followed the archlinux packaging naming ( https://aur.archlinux.org/packages/cozy-audiobooks/ ), also there is a python package called cozy in ./pkgs/development/python-modules/cozy/ and having audiobooks in the name makes clear what is about listening to audiobooks and what is about synthesizer.
i will change the name in the commit though.

GrahamcOfBorg · 2018-10-11T13:20:34Z

Success on x86_64-linux (full log)

Attempted: cozy

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3/bin/com.github.geigi.cozy
Wrapping program /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3/bin/cozy
shrinking RPATHs of ELF executables and libraries in /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3/lib  /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3/bin
patching script interpreter paths in /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3
checking for references to /build in /nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3...
wrapping `/nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3/bin/.com.github.geigi.cozy-wrapped'...
/nix/store/snx5s4pyyq21m0gggvb0yz97wk5hdn4m-cozy-0.6.3

GrahamcOfBorg · 2018-10-11T13:23:09Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cozy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-11T13:37:49Z

Success on aarch64-linux (full log)

Attempted: cozy

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3/bin/cozy
Wrapping program /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3/bin/com.github.geigi.cozy
shrinking RPATHs of ELF executables and libraries in /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3/lib  /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3/bin
patching script interpreter paths in /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3
checking for references to /build in /nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3...
wrapping `/nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3/bin/.com.github.geigi.cozy-wrapped'...
/nix/store/9qfnpqc6sw229bcsvrv28yiqskj118r9-cozy-0.6.3

worldofpeace · 2018-10-11T18:12:03Z

LGTM but I'm not the best person to review peewee here.

cc @FRidh @dotlambda for pythonPackages.peewee

makefu · 2018-10-13T22:24:54Z

@GrahamcOfBorg build python2Packages.peewee

GrahamcOfBorg · 2018-10-13T22:25:29Z

Success on x86_64-linux (full log)

Attempted: python2Packages.peewee

Partial log (click to expand)

Ran 619 tests in 13.469s

OK (skipped=56)
Unable to import APSW extension tests, skipping.
Unable to import sqlite C extension tests, skipping.
Unable to import mysql-connector, skipping mysql_ext tests.
Unable to import postgres extension tests, skipping.
Unable to import SQLCipher extension tests, skipping.
Unable to import sqlite extension tests, skipping.
/nix/store/vh7s30lvvbv815m71iwprxn76z0l2syi-python2.7-peewee-3.7.0

GrahamcOfBorg · 2018-10-13T22:25:38Z

Success on x86_64-darwin (full log)

Attempted: python2Packages.peewee

Partial log (click to expand)

Ran 619 tests in 6.799s

OK (skipped=56)
Unable to import APSW extension tests, skipping.
Unable to import sqlite C extension tests, skipping.
Unable to import mysql-connector, skipping mysql_ext tests.
Unable to import postgres extension tests, skipping.
Unable to import SQLCipher extension tests, skipping.
Unable to import sqlite extension tests, skipping.
/nix/store/v9ixkxd3bj9radp8acvc2kfp1y8a28fv-python2.7-peewee-3.7.0

GrahamcOfBorg · 2018-10-13T22:25:42Z

Success on aarch64-linux (full log)

Attempted: python2Packages.peewee

Partial log (click to expand)

Ran 619 tests in 5.148s

OK (skipped=56)
Unable to import APSW extension tests, skipping.
Unable to import sqlite C extension tests, skipping.
Unable to import mysql-connector, skipping mysql_ext tests.
Unable to import postgres extension tests, skipping.
Unable to import SQLCipher extension tests, skipping.
Unable to import sqlite extension tests, skipping.
/nix/store/m02dghpyd5r509b2p0qjygm8fm5mdvp9-python2.7-peewee-3.7.0

worldofpeace · 2018-10-13T22:40:39Z

pkgs/development/python-modules/peewee/default.nix

+buildPythonPackage rec {
+
+  pname = "peewee";
+  version = "3.7.0";


They're at 3.7.1 now

i cross fingers that they do not release a new version until tomorrow

worldofpeace · 2018-10-13T22:41:58Z

pkgs/development/python-modules/peewee/default.nix

+
+  pname = "peewee";
+  version = "3.7.0";
+  src = fetchFromGitHub {


probably should use fetchPypi

the pypi package is missing the tests

Maybe a comment like that then.

GrahamcOfBorg · 2018-10-14T00:32:26Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cozy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-14T00:34:48Z

Success on x86_64-linux (full log)

Attempted: cozy

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3/bin/com.github.geigi.cozy
Wrapping program /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3/bin/cozy
shrinking RPATHs of ELF executables and libraries in /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3/lib  /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3/bin
patching script interpreter paths in /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3
checking for references to /build in /nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3...
wrapping `/nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3/bin/.com.github.geigi.cozy-wrapped'...
/nix/store/cjh1b72q8rl4dzhg97ngjvzq7zw1zps1-cozy-0.6.3

GrahamcOfBorg · 2018-10-14T00:37:24Z

Success on aarch64-linux (full log)

Attempted: cozy

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3/bin/cozy
Wrapping program /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3/bin/com.github.geigi.cozy
shrinking RPATHs of ELF executables and libraries in /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3/lib  /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3/bin
patching script interpreter paths in /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3
checking for references to /build in /nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3...
wrapping `/nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3/bin/.com.github.geigi.cozy-wrapped'...
/nix/store/3gsprd940yyip4rvrl7riirsiw599kv1-cozy-0.6.3

worldofpeace · 2018-10-14T21:37:09Z

@makefu Thanks for your contribution ❇️ 🎆

makefu requested a review from FRidh as a code owner October 1, 2018 22:21

GrahamcOfBorg added the 6.topic: python label Oct 1, 2018

makefu force-pushed the pkgs/cozy-audiobooks/init branch from 31304e7 to a169937 Compare October 1, 2018 23:58

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 2, 2018

worldofpeace reviewed Oct 10, 2018

View reviewed changes

pkgs/applications/audio/cozy-audiobooks/default.nix Show resolved Hide resolved

worldofpeace reviewed Oct 10, 2018

View reviewed changes

makefu force-pushed the pkgs/cozy-audiobooks/init branch from a169937 to 0a2dab2 Compare October 11, 2018 04:15

worldofpeace reviewed Oct 11, 2018

View reviewed changes

makefu force-pushed the pkgs/cozy-audiobooks/init branch from 0a2dab2 to b75f211 Compare October 11, 2018 13:02

worldofpeace reviewed Oct 13, 2018

View reviewed changes

makefu added 2 commits October 14, 2018 02:13

pythonPackages.peewee: init at 3.7.1

ff44417

cozy: init at 0.6.3

f20899d

makefu force-pushed the pkgs/cozy-audiobooks/init branch from b75f211 to f20899d Compare October 14, 2018 00:15

FRidh merged commit 49b9959 into NixOS:master Oct 14, 2018

		@@ -653,6 +653,8 @@ with pkgs;

		chkcrontab = callPackage ../tools/admin/chkcrontab { };

		cozy-audiobooks = callPackage ../applications/audio/cozy-audiobooks { };

cozy-audiobooks: init at 0.6.3 #47631

cozy-audiobooks: init at 0.6.3 #47631

Conversation

makefu commented Oct 1, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

worldofpeace Oct 10, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

worldofpeace Oct 10, 2018 • edited

Choose a reason for hiding this comment

makefu commented Oct 10, 2018

Choose a reason for hiding this comment

worldofpeace commented Oct 11, 2018

worldofpeace Oct 11, 2018 • edited

Choose a reason for hiding this comment

makefu commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

worldofpeace commented Oct 11, 2018

makefu commented Oct 13, 2018

GrahamcOfBorg commented Oct 13, 2018

GrahamcOfBorg commented Oct 13, 2018

GrahamcOfBorg commented Oct 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

GrahamcOfBorg commented Oct 14, 2018

worldofpeace commented Oct 14, 2018

worldofpeace Oct 10, 2018 •

edited

worldofpeace Oct 10, 2018 •

edited

worldofpeace Oct 11, 2018 •

edited