Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome: use default patchelf, "fixes" nacl_helper crashing. #47612

Merged
merged 1 commit into from Oct 19, 2018
Merged

google-chrome: use default patchelf, "fixes" nacl_helper crashing. #47612

merged 1 commit into from Oct 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 1, 2018

I'm not sure what the problem is, precisely, but even so
this was preventing use of things like cast'ing--
not that I'm entirely clear on what that would be the case either :/.

Err on caution and let's go back to what the situation was before
and fix it properly when we better understand the issue.

  • I'm seeing "nacl_helper" crashing and it didn't before
    • other than journalctl logs (and coredumpctl) browser seems to work
      with only noticed difference being inability to cast to my
      chromecast.
  • If you attempt to run the 'nacl_helper' binary produced before/after
    this change the one patched by unstable crashes while the other
    spams your console since it's not really meant to be run that way :P.

Sorry for the churn, as far as regressions go it was subtle and
took me some time to even really be sure what caused it xD.

Wouldn't mind someone checking if they at least see the crashing
desribed above (no clue if my chromecast is just being moody)
to give some confidence this is a step (back? forward? ONWARD!)
in the right direction.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
google-chrome: use default patchelf, "fixes" nacl_helper crashing.
e7345ef 
I'm not sure what the problem is, precisely, but even so
this was preventing use of things like cast'ing--
not that I'm entirely clear on what that would be the case either :/.

Err on caution and let's go back to what the situation was before
and fix it properly when we better understand the issue.
@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: google-chrome

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: google-chrome

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: google-chrome

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@matthewbauer
Copy link
Member

Hmmm... Maybe you should open an issue in patchelf? Eventually there will be a release and we'll hit these problems.

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2018

Do you still have the binaries of both? radiff2 could spot the difference.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 6, 2018

Well I'm not sure I can look into this just now-- and assuming this impacts others I'm inclined to see this merged (effectively reverting the change I introduced causing the regression by moving to patchelfUnstable for this). I've applied it locally in the meantime, so it seems almost dishonest to leave it broken upstream O:).

But it would be good to isolate the issue and report upstream, just not sure when that'll happen :).

@Mic92
Copy link
Member

Mic92 commented Oct 6, 2018

make senses

@dtzWill dtzWill merged commit ca67b33 into NixOS:master Oct 19, 2018
@dtzWill dtzWill deleted the fix/use-regular-patchelf-with-chrome branch October 19, 2018 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @matthewbauer @Mic92