Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin: 0.16.3 -> 0.17.0 #47613

Closed
wants to merge 1 commit into from
Closed

bitcoin: 0.16.3 -> 0.17.0 #47613

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 1, 2018

https://github.com/bitcoin/bitcoin/releases/tag/v0.17.0

I've built/tested this (and a few rc's leading to it) on a branch that's
pretty much master with a few changes I don't expect to be relevant but
ust FYI :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bitcoin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0/bin/bitcoin-cli
shrinking /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0/bin/bitcoind
shrinking /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0/lib  /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0/bin
patching script interpreter paths in /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0
checking for references to /build in /nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0...
postPatchMkspecs
/nix/store/0zp78scyax43qvh1dli6asm35c5a690v-bitcoin-0.17.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0/bin/bitcoin-cli
shrinking /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0/bin/bitcoin-qt
shrinking /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0/bin/bitcoin-tx
gzipping man pages under /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0/lib  /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0/bin
patching script interpreter paths in /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0
checking for references to /build in /nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0...
postPatchMkspecs
/nix/store/iv2x6z1na8pnxk49lh03xc25dryd0pzm-bitcoin-0.17.0

@roconnor
Copy link
Contributor

roconnor commented Oct 3, 2018

NACK. The SHA256 hash doesn't match the ones signed for by the Bitcoin Core GPG key.

Don't worry I'll have a new PR ready soon.

@roconnor roconnor closed this Oct 3, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Oct 3, 2018

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @roconnor