Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifi updates #47620

Merged
merged 2 commits into from Oct 2, 2018
Merged

Unifi updates #47620

merged 2 commits into from Oct 2, 2018

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 1, 2018

Motivation for this change

Update all unifi packages to the latest available version.

I did not test if the unifiTesting package is working correctly. I only made sure it builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the names in the commit messages should be unifiStable and unifiTesting.

@bachp
Copy link
Member Author

bachp commented Oct 2, 2018

@timokau I just use the same naming as some of previous update commits did. But you are right the most recent ones use the names you proposed. I will update the PR.

@timokau
Copy link
Member

timokau commented Oct 2, 2018

According to CONTRIBUTING.md it should be the package name. Maybe it was different before, maybe someone mistyped. Its not a big deal either way, but helps when searching for past changes to a package.

@timokau
Copy link
Member

timokau commented Oct 2, 2018

Please notify when you have changed it as github won't send a notification.

@bachp
Copy link
Member Author

bachp commented Oct 2, 2018

@timokau PR updated.

@timokau
Copy link
Member

timokau commented Oct 2, 2018

@GrahamcOfBorg build unifiStable unifiTesting

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: unifiStable, unifiTesting

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: unifiStable, unifiTesting

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: unifiStable, unifiTesting

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@timokau
Copy link
Member

timokau commented Oct 2, 2018

Thanks!

@timokau timokau merged commit b3e2f32 into NixOS:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants