Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bento4: init at 1.5.1-624 #47632

Merged
merged 1 commit into from Oct 18, 2018
Merged

bento4: init at 1.5.1-624 #47632

merged 1 commit into from Oct 18, 2018

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 1, 2018

Motivation for this change

adds the bento4 package with tools for working with MPEG DASH

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bento4

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: bento4

Partial log (click to expand)

[ 76%] Building CXX object CMakeFiles/ap4.dir/Source/C++/System/StdC/Ap4StdCFileByteStream.cpp.o
[ 77%] Building CXX object CMakeFiles/ap4.dir/Source/C++/System/Posix/Ap4PosixRandom.cpp.o
/build/source/Source/C++/Crypto/Ap4AesBlockCipher.cpp:93:4: error: #error AP4_PLATFORM_BYTE_ORDER is not set
 #  error AP4_PLATFORM_BYTE_ORDER is not set
    ^~~~~
make[2]: *** [CMakeFiles/ap4.dir/build.make:1610: CMakeFiles/ap4.dir/Source/C++/Crypto/Ap4AesBlockCipher.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:702: CMakeFiles/ap4.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
builder for '/nix/store/60fm2hq8cmkflcjz4w6a6bnpjf8rz8kd-bento4-1.5.1-624.drv' failed with exit code 2
error: build of '/nix/store/60fm2hq8cmkflcjz4w6a6bnpjf8rz8kd-bento4-1.5.1-624.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bento4

Partial log (click to expand)

shrinking /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/bin/mp42hls
shrinking /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/bin/mp4tag
shrinking /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/bin/mp4info
shrinking /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/bin/mp4compact
shrinking /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/bin/mp4extract
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/lib  /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624/bin
patching script interpreter paths in /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624
checking for references to /build in /nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624...
/nix/store/nc70dhwvmiry8979556nkhas5w7qib3c-bento4-1.5.1-624

@makefu
Copy link
Contributor Author

makefu commented Oct 2, 2018

does not seem to build on aarch64, sad

@nlewo
Copy link
Member

nlewo commented Oct 5, 2018

Could you restrict the platform list (or fix the aarch64 build)?

@makefu
Copy link
Contributor Author

makefu commented Oct 5, 2018

@nlewo actually i wanted to do this but i just haven't had the time till now. brb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bento4

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: bento4

Partial log (click to expand)

[ 76%] Building CXX object CMakeFiles/ap4.dir/Source/C++/System/StdC/Ap4StdCFileByteStream.cpp.o
[ 77%] Building CXX object CMakeFiles/ap4.dir/Source/C++/System/Posix/Ap4PosixRandom.cpp.o
/build/source/Source/C++/Crypto/Ap4AesBlockCipher.cpp:93:4: error: #error AP4_PLATFORM_BYTE_ORDER is not set
 #  error AP4_PLATFORM_BYTE_ORDER is not set
    ^~~~~
make[2]: *** [CMakeFiles/ap4.dir/build.make:1610: CMakeFiles/ap4.dir/Source/C++/Crypto/Ap4AesBlockCipher.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:702: CMakeFiles/ap4.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
builder for '/nix/store/2q92pfqz6snijsmpfv9373mbg8ammadk-bento4-1.5.1-624.drv' failed with exit code 2
error: build of '/nix/store/2q92pfqz6snijsmpfv9373mbg8ammadk-bento4-1.5.1-624.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bento4

Partial log (click to expand)

shrinking /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/bin/mp42hls
shrinking /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/bin/mp4tag
shrinking /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/bin/mp4info
shrinking /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/bin/mp4compact
shrinking /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/bin/mp4extract
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/lib  /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624/bin
patching script interpreter paths in /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624
checking for references to /build in /nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624...
/nix/store/sgdhdxpgw8v9y46c13vifkz2bqpgybv1-bento4-1.5.1-624

@makefu
Copy link
Contributor Author

makefu commented Oct 6, 2018

mhh it should not be evaluated by ofborg for aarch64, i copy-pasted the snippet from another recipe, any other idea to do it?

@xeji
Copy link
Contributor

xeji commented Oct 17, 2018

meta.platforms = platforms.linux; meta.broken = stdenv.isAarch64; should work.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bento4

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bento4

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bento4

Partial log (click to expand)

shrinking /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/bin/mp42hls
shrinking /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/bin/mp4tag
shrinking /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/bin/mp4info
shrinking /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/bin/mp4compact
shrinking /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/bin/mp4extract
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/lib  /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624/bin
patching script interpreter paths in /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624
checking for references to /build in /nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624...
/nix/store/9jg1yisp9wdxp8kcxpvvycsah7ffg6z7-bento4-1.5.1-624

@xeji xeji merged commit 17685a4 into NixOS:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makefu @GrahamcOfBorg @nlewo @xeji