Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: Misc cross fixes for 18.09 #47627

Merged
merged 3 commits into from Oct 1, 2018
Merged

ghc: Misc cross fixes for 18.09 #47627

merged 3 commits into from Oct 1, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #47626.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
ghcHEAD: Force INTEGER_LIBRARY like the other GHCs
d4b5df7 
We really need to abstract to avoid these copy-paste errors.
@Ericson2314
ghcHEAD: Copy android hack that other GHCs have
cb442d9 
Not sure why this one doesn't
@Ericson2314
ghc 8.2.2: Backport cross fixes from 8.4.3
b191133 
Other patches are also needed for a working build, but that doesn't mean
these patches are any less necessary.
@Ericson2314 Ericson2314 changed the title Ghc cross fixes ghc: Misc cross fixes for 18.09 Oct 1, 2018
@Ericson2314 Ericson2314 merged commit d296abb into NixOS:release-18.09 Oct 1, 2018
@Ericson2314 Ericson2314 deleted the ghc-cross-fixes branch October 1, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg