Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bitlbee: add pam option #47603

Merged
merged 2 commits into from Oct 4, 2018
Merged

nixos/bitlbee: add pam option #47603

merged 2 commits into from Oct 4, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 1, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
bitlbee: disable gcov
14cc9a2 
Code coverage reports is not useful at all for users.
This is a feature for developer.
@Mic92
nixos/bitlbee: option to use pam
d334c1c
@Mic92
Copy link
Member Author

Mic92 commented Oct 1, 2018

cc @pSub

@Mic92
Copy link
Member Author

Mic92 commented Oct 1, 2018

Tested on my server.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bitlbee

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1
shrinking /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1/sbin/bitlbee
gzipping man pages under /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1/lib  /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1/sbin
patching script interpreter paths in /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1
checking for references to /build in /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1...
moving /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1/sbin/* to /nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1/bin
/nix/store/aswf1d61g7jlwvdzp0i6y9vc0j6lzgg9-bitlbee-3.5.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bitlbee

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bitlbee

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1
shrinking /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1/sbin/bitlbee
gzipping man pages under /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1/lib  /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1/sbin
patching script interpreter paths in /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1
checking for references to /build in /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1...
moving /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1/sbin/* to /nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1/bin
/nix/store/jhd1jvikajv8bj6vqkjv4niy4h3s1avz-bitlbee-3.5.1

pSub
pSub approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pSub pSub merged commit b9e7935 into NixOS:master Oct 4, 2018
@Mic92 Mic92 deleted the bitlbee branch October 4, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @pSub