Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapta-gtk-theme: 3.94.0.149 -> 3.95.0.1 #47619

Closed
wants to merge 2 commits into from
Closed

adapta-gtk-theme: 3.94.0.149 -> 3.95.0.1 #47619

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 1, 2018

The 3.94 -> 3.95 is apparently a bit of a rewrite,
all I know is everything looks better ;) --
I believe works better with latest/greatest as well :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
adapta-gtk-theme: 3.94.0.149 -> 3.95.0.1
2bf4014 
Apparently it's much more of an update than the version
numbers might lead you to believe :).

https://github.com/adapta-project/adapta-gtk-theme/releases/tag/3.95.0.1
@dtzWill
adapta: remove unrecognized flags, be explicit about what we want
431688a 
Also while visiting this:
* enable plank support! :)
* enable parallel build (not make-based parallelism) since we're
  providing the 'parallel' utility it wants for that purpose already.
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: adapta-gtk-theme

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: adapta-gtk-theme

Partial log (click to expand)

make[3]: Leaving directory '/build/source'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m0paz3ywv2kfz0bzvnafjbfalmkaagck-adapta-gtk-theme-3.95.0.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/m0paz3ywv2kfz0bzvnafjbfalmkaagck-adapta-gtk-theme-3.95.0.1
checking for references to /build in /nix/store/m0paz3ywv2kfz0bzvnafjbfalmkaagck-adapta-gtk-theme-3.95.0.1...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: adapta-gtk-theme

Partial log (click to expand)

make[3]: Leaving directory '/build/source'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/px9a2ryllgwar6j4402v5wa76gwa5dw6-adapta-gtk-theme-3.95.0.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/px9a2ryllgwar6j4402v5wa76gwa5dw6-adapta-gtk-theme-3.95.0.1
checking for references to /build in /nix/store/px9a2ryllgwar6j4402v5wa76gwa5dw6-adapta-gtk-theme-3.95.0.1...

@dtzWill
Copy link
Member Author

dtzWill commented Oct 1, 2018

Dup of #47610, which does have the customization. I don't have a strong preference either way, so whatever folks like best is good to me :).

@timokau
Copy link
Member

timokau commented Oct 1, 2018

Oh I didn't even realize these two update the same package :D

Definitely two opposite extremes of configurability. I slightly prefer more configurability, but practically it doesn't make much difference.

@timokau timokau mentioned this pull request Oct 1, 2018
Closed
9 tasks
@tadfisher
Copy link
Contributor

Upstream has removed the 3.95 release and will move these changes to a new theme.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 5, 2018

Oh, good to know! Thanks!

@dtzWill dtzWill closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @timokau @tadfisher