Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-rotate-key: 1.0.0 -> 1.0.3 #47607

Merged
merged 1 commit into from Oct 6, 2018
Merged

aws-rotate-key: 1.0.0 -> 1.0.3 #47607

merged 1 commit into from Oct 6, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Oct 1, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Oct 1, 2018

@GrahamcOfBorg build aws_rotate_key

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: aws_rotate_key

Partial log (click to expand)

Cannot nix-instantiate `aws_rotate_key' because:
error: attribute 'aws_rotate_key' in selection path 'aws_rotate_key' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: aws_rotate_key

Partial log (click to expand)

Cannot nix-instantiate `aws_rotate_key' because:
error: attribute 'aws_rotate_key' in selection path 'aws_rotate_key' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: aws_rotate_key

Partial log (click to expand)

Cannot nix-instantiate `aws_rotate_key' because:
error: attribute 'aws_rotate_key' in selection path 'aws_rotate_key' not found

@kalbasit
Copy link
Member

kalbasit commented Oct 1, 2018

@GrahamcOfBorg build aws-rotate-key

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-rotate-key

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/slkqxhhfc96zva3zrz3xsya9g33cdjms-aws-rotate-key-1.0.2-bin
shrinking /nix/store/slkqxhhfc96zva3zrz3xsya9g33cdjms-aws-rotate-key-1.0.2-bin/bin/aws-rotate-key
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/slkqxhhfc96zva3zrz3xsya9g33cdjms-aws-rotate-key-1.0.2-bin/bin
patching script interpreter paths in /nix/store/slkqxhhfc96zva3zrz3xsya9g33cdjms-aws-rotate-key-1.0.2-bin
checking for references to /build in /nix/store/slkqxhhfc96zva3zrz3xsya9g33cdjms-aws-rotate-key-1.0.2-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/slkqxhhfc96zva3zrz3xsya9g33cdjms-aws-rotate-key-1.0.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-rotate-key

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dfh8gwnrikkdl0ag0nk8jqfrcmrqc9ll-aws-rotate-key-1.0.2-bin
shrinking /nix/store/dfh8gwnrikkdl0ag0nk8jqfrcmrqc9ll-aws-rotate-key-1.0.2-bin/bin/aws-rotate-key
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dfh8gwnrikkdl0ag0nk8jqfrcmrqc9ll-aws-rotate-key-1.0.2-bin/bin
patching script interpreter paths in /nix/store/dfh8gwnrikkdl0ag0nk8jqfrcmrqc9ll-aws-rotate-key-1.0.2-bin
checking for references to /build in /nix/store/dfh8gwnrikkdl0ag0nk8jqfrcmrqc9ll-aws-rotate-key-1.0.2-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/dfh8gwnrikkdl0ag0nk8jqfrcmrqc9ll-aws-rotate-key-1.0.2-bin

@timokau
Copy link
Member

timokau commented Oct 1, 2018

Can you please fix the package name in the commit message?

@mbode mbode changed the title aws_rotate_key: 1.0.0 -> 1.0.2 aws-rotate-key: 1.0.0 -> 1.0.2 Oct 3, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 4, 2018

Apparently upstream already published 1.0.3 to fix the version reported by the tool.
@mbode would you be willing to make this PR about 1.0.0 -> 1.0.3 please?

@mbode mbode changed the title aws-rotate-key: 1.0.0 -> 1.0.2 aws-rotate-key: 1.0.0 -> 1.0.3 Oct 6, 2018
@mbode
Copy link
Contributor Author

mbode commented Oct 6, 2018

@c0bw3b Thanks for noticing!

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 6, 2018 

$ ./result-bin/bin/aws-rotate-key --version
1.0.3

@c0bw3b c0bw3b merged commit d27fc43 into NixOS:master Oct 6, 2018
@mbode mbode deleted the aws-rotate-key_1_0_2 branch October 6, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit requested changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbode @timokau @GrahamcOfBorg @kalbasit @c0bw3b