Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner-v1: remove v1 package #47624

Merged
merged 1 commit into from Oct 1, 2018
Merged

gitlab-runner-v1: remove v1 package #47624

merged 1 commit into from Oct 1, 2018

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 1, 2018

Motivation for this change

It was required for gitlab < 9 which is not supported anymore since some time.

While removinf the V1 the patch was refreshed to cleanly work with version 11.x

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bachp
gitlab-runner-v1: remove v1 package
41df721 
It was required for gitlab < 9 which is not supported anymore since some time.

While removinf the V1 the patch was refreshed to cleanly work with version 11.x
@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

@GrahamcOfBorg build gitlab-runner

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitlab-runner

Partial log (click to expand)

find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
find: '/nix/store/yhm2ixrr1w120v0yh8iwqq6k0ycbslx4-gitlab-runner-11.3.1': No such file or directory
/nix/store/9ajwizkm0riz4g477pc1pdl7y1703aal-gitlab-runner-11.3.1-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitlab-runner

Partial log (click to expand)

gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/opencontainers/runc/libcontainer/devices
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/oci
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/prometheus/client_model/go
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/matttproud/golang_protobuf_extensions/pbutil
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/registry/storage/cache
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/registry/storage/cache/memory
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/registry/client
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/registry/client/auth
builder for '/nix/store/qgqbsk4374pgv62v98hy6xdb78g4b9gk-gitlab-runner-11.3.1.drv' failed with exit code 24
error: build of '/nix/store/qgqbsk4374pgv62v98hy6xdb78g4b9gk-gitlab-runner-11.3.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab-runner

Partial log (click to expand)

shrinking /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin/bin/pull-images-for-tests
shrinking /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin/bin/gitlab-runner
shrinking /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin/bin/gitlab-runner-helper
shrinking /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin/bin/scripts
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin/bin
patching script interpreter paths in /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin
checking for references to /build in /nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/myl869rk3h0vbk7sl60da64vm5lzn4f0-gitlab-runner-11.3.1-bin

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

aarch64 failure looks unrelated, see #47623 (comment)

@xeji xeji merged commit 9dbb71b into NixOS:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @xeji @GrahamcOfBorg