Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-8.2.2: Fix which hsc2hs is installed on cross #47644

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Oct 2, 2018

Motivation for this change

These commits all ended up on later GHCs, and are already being patched
in for ghc-8.4.3 in nixpkgs.

These patches actually largely cancel out, but I figure it's better to fetch original commits than make a new patch with looser provenance and no good place to put it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

These commits all ended up on later GHCs, and are already being patched
in for ghc-8.4.3 in nixpkgs.
@Ericson2314 Ericson2314 changed the base branch from master to release-18.09 October 2, 2018 04:45
@Ericson2314 Ericson2314 changed the base branch from release-18.09 to master October 2, 2018 04:46
@Ericson2314 Ericson2314 merged commit e231a37 into NixOS:master Oct 2, 2018
@Ericson2314 Ericson2314 deleted the ghc-8.2-hsc2hs branch October 2, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants