Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elm-format: 0.8.0 -> 0.8.1 #47651

Merged
merged 1 commit into from Oct 3, 2018
Merged

elm-format: 0.8.0 -> 0.8.1 #47651

merged 1 commit into from Oct 3, 2018

Conversation

avh4
Copy link
Member

@avh4 avh4 commented Oct 2, 2018

Motivation for this change

New official release of elm-format: https://github.com/avh4/elm-format/releases/tag/0.8.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages.elm-format

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: elmPackages.elm-format

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: elmPackages.elm-format

Partial log (click to expand)

  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:470:12 in Cabal-2.0.1.0:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:570:20 in Cabal-2.0.1.0:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.0.1.0:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:174:19 in Cabal-2.0.1.0:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:119:27 in Cabal-2.0.1.0:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing dependencies:
tasty-quickcheck >=0.9.2 && <0.10
builder for '/nix/store/ccp51iwsq0bdyfjzj6hga3nc0x1ldwdk-elm-format-0.8.1.drv' failed with exit code 1
error: build of '/nix/store/ccp51iwsq0bdyfjzj6hga3nc0x1ldwdk-elm-format-0.8.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: elmPackages.elm-format

Partial log (click to expand)

  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:470:12 in Cabal-2.0.1.0:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:570:20 in Cabal-2.0.1.0:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.0.1.0:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:174:19 in Cabal-2.0.1.0:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:119:27 in Cabal-2.0.1.0:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing dependencies:
tasty-quickcheck >=0.9.2 && <0.10
builder for '/nix/store/6vxc5l62ppnmrdyrsdwc8g00f517sh53-elm-format-0.8.1.drv' failed with exit code 1
error: build of '/nix/store/6vxc5l62ppnmrdyrsdwc8g00f517sh53-elm-format-0.8.1.drv' failed

@avh4
Copy link
Member Author

avh4 commented Oct 2, 2018

I guess I need to upgrade elm-format to use tasty-quickcheck-0.10, and I need to find instructions for how to build this derivation against latest nixpkgs locally.

@avh4
Copy link
Member Author

avh4 commented Oct 3, 2018

I was able to reproduce the failure locally, and the easiest fix seems to be just to disable the checks (which is what 0.8.0 did).

However, I noticed that the compiled package doesn't include the version number in the binary correctly, so I want to fix that before I update this PR. (See avh4/elm-format#559 )

@avh4 avh4 mentioned this pull request Oct 3, 2018
Merged
@avh4
Copy link
Member Author

avh4 commented Oct 3, 2018

@domenkozar okay, I think this should be ready now

@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages.elm-format

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: elmPackages.elm-format

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elmPackages.elm-format

Partial log (click to expand)

shrinking /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1/bin/elm-format
shrinking /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1/lib/ghc-8.2.2/x86_64-linux-ghc-8.2.2/elm-format-0.8.1-7j79M9xPhUa9jLBEDFxezN/HSelm-format-0.8.1-7j79M9xPhUa9jLBEDFxezN.o
wrong ELF type
shrinking /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1/lib/ghc-8.2.2/x86_64-linux-ghc-8.2.2/libHSelm-format-0.8.1-7j79M9xPhUa9jLBEDFxezN-ghc8.2.2.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1/lib  /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1/bin
patching script interpreter paths in /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1
checking for references to /build in /nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1...
wrong ELF type
/nix/store/ycgksjr6f5hmggijwjy3z8kd4a440x9s-elm-format-0.8.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: elmPackages.elm-format

Partial log (click to expand)

Installing library in /nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/elm-format-0.8.1-7j79M9xPhUa9jLBEDFxezN
Installing executable elm-format in /nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1/bin
Warning: The directory
/nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1/bin is not in the
system search path.
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1/lib  /nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1/bin
patching script interpreter paths in /nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1
/nix/store/yawvxrgx1gwn5p1vslwg7b6kb5yd972m-elm-format-0.8.1

@domenkozar domenkozar merged commit 67f58ee into NixOS:master Oct 3, 2018
@domenkozar
Copy link
Member

Thank you @avh4 :)

@avh4 avh4 deleted the patch-1 branch October 3, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avh4 @domenkozar @GrahamcOfBorg @Janik-Haag