Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv2svn: 2.4.0 -> 2.5.0 #47635

Merged
merged 1 commit into from Oct 2, 2018
Merged

csv2svn: 2.4.0 -> 2.5.0 #47635

merged 1 commit into from Oct 2, 2018

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 1, 2018

Motivation for this change

update csv2svn to the latest version.
use buildPythonApplication instead of manual setup.py call

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@makefu
csv2svn: 2.4.0 -> 2.5.0
06cde52 
use buildPythonApplication instead of manual setup.py call
@srhb
Copy link
Contributor

srhb commented Oct 2, 2018

@GrahamcOfBorg build csv2svn

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: csv2svn

Partial log (click to expand)

Cannot nix-instantiate `csv2svn' because:
error: attribute 'csv2svn' in selection path 'csv2svn' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: csv2svn

Partial log (click to expand)

Cannot nix-instantiate `csv2svn' because:
error: attribute 'csv2svn' in selection path 'csv2svn' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: csv2svn

Partial log (click to expand)

Cannot nix-instantiate `csv2svn' because:
error: attribute 'csv2svn' in selection path 'csv2svn' not found

@srhb
Copy link
Contributor

srhb commented Oct 2, 2018

@GrahamcOfBorg build cvs2svn

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cvs2svn

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0/lib  /nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0/bin
patching script interpreter paths in /nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0
checking for references to /build in /nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0...
wrapping `/nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0/bin/.cvs2git-wrapped'...
wrapping `/nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0/bin/.cvs2svn-wrapped'...
wrapping `/nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0/bin/.cvs2bzr-wrapped'...
/nix/store/l9d2lzpfbcnkwg849h2lyqwkbcq3cjdk-cvs2svn-2.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cvs2svn

Partial log (click to expand)

Successfully installed cvs2svn-2.5.0
/private/tmp/nix-build-cvs2svn-2.5.0.drv-0/cvs2svn-2.5.0
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0/lib  /nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0/bin
patching script interpreter paths in /nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0
wrapping `/nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0/bin/.cvs2bzr-wrapped'...
wrapping `/nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0/bin/.cvs2git-wrapped'...
wrapping `/nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0/bin/.cvs2svn-wrapped'...
/nix/store/awb4x3qrg0xvsvazcrgxnnwr5i5z3lqr-cvs2svn-2.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cvs2svn

Partial log (click to expand)

/build/cvs2svn-2.5.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0/lib  /nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0/bin
patching script interpreter paths in /nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0
checking for references to /build in /nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0...
wrapping `/nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0/bin/.cvs2git-wrapped'...
wrapping `/nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0/bin/.cvs2svn-wrapped'...
wrapping `/nix/store/3kf6l6a3lhxhnqf170z6dvcacp470c7d-cvs2svn-2.5.0/bin/.cvs2bzr-wrapped'...

@xeji xeji merged commit 3790cf7 into NixOS:master Oct 2, 2018
@makefu
Copy link
Contributor Author

makefu commented Oct 2, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makefu @srhb @GrahamcOfBorg @xeji