Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sit: 0.4.0 -> 0.4.1 #47643

Closed
wants to merge 1 commit into from
Closed

sit: 0.4.0 -> 0.4.1 #47643

wants to merge 1 commit into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Oct 2, 2018

Motivation for this change

New version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 2, 2018

@GrahamcOfBorg build sit

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sit

Partial log (click to expand)


failures:
    record_should_sign_if_configured
    record_should_sign_if_instructed_cmdline

test result: FAILED. 13 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p sit --test command_record'
builder for '/nix/store/wmfk6sjdjkqczz40q3yp794k81bcssbx-sit-0.4.1.drv' failed with exit code 101
error: build of '/nix/store/wmfk6sjdjkqczz40q3yp794k81bcssbx-sit-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: sit

Partial log (click to expand)

test no_records ... ok
test pgp_no_signature ... ok
test query ... ok
test record ... ok
test repo_over_named_user_filter ... ok
test repo_over_named_user_query ... ok
test pgp_signature ... test pgp_signature has been running for over 60 seconds
test pgp_signature_wrong_data ... test pgp_signature_wrong_data has been running for over 60 seconds
building of '/nix/store/ammmgm6l81mwpdzsl0w2bhrwhq45d2nq-sit-0.4.1.drv' timed out after 1800 seconds
error: build of '/nix/store/ammmgm6l81mwpdzsl0w2bhrwhq45d2nq-sit-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sit

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1
shrinking /nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1/bin/sit
shrinking /nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1/bin/sit-web
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1/bin
patching script interpreter paths in /nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1
checking for references to /build in /nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1...
/nix/store/bj7xh0d55x4gv292g5047d9r6dfwzbg2-sit-0.4.1

@yrashk
Copy link
Contributor Author

yrashk commented Oct 2, 2018 via email

@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

Would it be possible to disable the gpg test for now?

@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

It also fails on my machine.

ryantm
ryantm requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable GPG tests for now

@aanderse
Copy link
Member

@yrashk are you able to continue with this PR?

@yrashk
Copy link
Contributor Author

yrashk commented May 14, 2019

I am working on a new version, so I am going to close this one.

@yrashk yrashk closed this May 14, 2019
@aanderse
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yrashk @xeji @GrahamcOfBorg @Mic92 @aanderse @ryantm @infinisil