Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.idea-community: add IntelliJ keyword to the longDescription #47650

Merged
merged 1 commit into from Oct 2, 2018
Merged

jetbrains.idea-community: add IntelliJ keyword to the longDescription #47650

merged 1 commit into from Oct 2, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Oct 2, 2018 •
edited

This should make it easier to find the package under the name
IntelliJ in eg. [1]

If possible, please backport :)

[1] https://nixos.org/nixos/packages.html#intellij

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ekleog
jetbrains.idea-community: add IntelliJ keyword to the longDescription
9cd0f88 
This should make it easier to find the package under the name
IntelliJ in eg. [1]

[1] https://nixos.org/nixos/packages.html#intellij
@Ekleog Ekleog requested a review from edwtjo as a code owner October 2, 2018 06:45
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jetbrains.idea-community

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jetbrains.idea-community

Partial log (click to expand)

shrinking /nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/idea-community-2018.2.4/plugins/android/lib/libwebp/linux/libwebp_jni64.so
shrinking /nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/idea-community-2018.2.4/plugins/android/lib/libwebp/linux/libwebp_jni.so
strip is hashed (/nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip)
stripping (with command strip and flags -S) in /nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/libexec  /nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/bin
patching script interpreter paths in /nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4
/nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/idea-community-2018.2.4/bin/idea.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/idea-community-2018.2.4/bin/format.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4/idea-community-2018.2.4/bin/inspect.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4...
/nix/store/fw7w74h9x1bdciqd1qpa1iz5c1m6bl8j-idea-community-2018.2.4

@xeji xeji merged commit 5f5905e into NixOS:master Oct 2, 2018
xeji pushed a commit that referenced this pull request Oct 2, 2018
@Ekleog @xeji
jetbrains.idea-community: add IntelliJ keyword to the longDescription (…
18749a7 
…#47650)

This should make it easier to find the package under the name
IntelliJ in eg. [1]

[1] https://nixos.org/nixos/packages.html#intellij

(cherry picked from commit 5f5905e)
@xeji
Copy link
Contributor

xeji commented Oct 2, 2018

backported: 18749a7

@Ekleog
Copy link
Member Author

Ekleog commented Oct 2, 2018

Thank you! :)

@Ekleog Ekleog deleted the patch-2 branch October 2, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @xeji