rustc: 1.29.0 -> 1.29.1 #47649
Merged
rustc: 1.29.0 -> 1.29.1 #47649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: rustc Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: rustc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: rustc Partial log (click to expand)
|
|
When backporting to 18.03 don't forget to also disable the checkPhase there as well. |
|
Maybe this should go straight to staging-next, since it's security sensitive. |
|
staging-next has been merged in the meantime so no need to change the branch anymore. |
|
@Mic92 I added those commits to this branch. Let me know if this looks good or if this can be merged :-) |
|
Success on aarch64-linux (full log) Attempted: rustc Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: rustc Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: rustc Partial log (click to expand)
|
|
@andir they can be actually squashed into one commit apart from that it looks good to me. |
From the changelog: - The standard library's `str::repeat` function contained an out of bounds write caused by an integer overflow. This has been fixed by deterministically panicking when an overflow happens.
andir
force-pushed
the
staging-rustc-1.29.1
branch
from
c77eaa5
to
6ad43a0
Compare
|
@Mic92 Done. |
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: rustc Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: rustc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: rustc Partial log (click to expand)
|
|
@andir did you backport this to staging-18.09? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixing a security sensitive bug in the rust stdlib.
From the changelog:
str::repeatfunction contained an out of bounds writecaused by an integer overflow. This has been fixed by deterministically
panicking when an overflow happens.
This change should not break anything that wasn't broken on 1.29.0 before. I have been rebuilding large portions of nixpkgs on the current staging head and didn't encounter many issues.
We should probably provide backports to 18.03 & 18.03 following the patch proposed on the original announcement mail.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)