Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: add libnotify to wrapper to enable notifications #47656

Merged
merged 1 commit into from Oct 2, 2018
Merged

jetbrains: add libnotify to wrapper to enable notifications #47656

merged 1 commit into from Oct 2, 2018

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Oct 2, 2018

Motivation for this change

System notifications weren't available in the corresponding menu. Also, the log showed:

ntellij.ui.SystemNotifications - Unable to load library 'libnotify.so.4': Native library (linux-x86-64/libnotify.so.4) not found in resource path (/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/bootstrap.jar:/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/extensions.jar:/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/util.jar:/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/jdom.jar:/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/log4j.jar:/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/trove4j.jar:/nix/store/qqsvlbrn6k6drb9bhd85zx1jv2fgp147-idea-community-2018.2.2/idea-community-2018.2.2/lib/jna.jar:/nix/store/llz3210kc2fmidfizx68k0hl8qzb5nzp-jetbrainsjdk-152b1248.6/lib/tools.jar)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from edwtjo as a code owner October 2, 2018 09:47
@Mic92 Mic92 merged commit 83f6cf8 into NixOS:master Oct 2, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

backport 9934f41

@kvtb kvtb mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmiddend @Mic92 @GrahamcOfBorg