pythonPackages.imageio: 1.6 -> 2.4.1 #49147

pmiddend · 2018-10-26T11:47:50Z

Motivation for this change

A normal update. I tried to keep the nix expression like it was before, although I'm not sure why there's a checkPhase and even check dependencies when doCheck is false.

I've tested the library itself.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

pmiddend · 2018-10-26T11:48:46Z

@GrahamcOfBorg build python36Packages.imageio

GrahamcOfBorg · 2018-10-26T11:49:05Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1/lib  /nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1/bin
patching script interpreter paths in /nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1
checking for references to /build in /nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1...
wrapping `/nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1/bin/imageio_remove_bin'...
wrapping `/nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1/bin/imageio_download_bin'...
pytestcachePhase
/nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-10-26T11:49:32Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1/lib  /nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1/bin
patching script interpreter paths in /nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1
checking for references to /build in /nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1...
wrapping `/nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1/bin/imageio_download_bin'...
wrapping `/nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1/bin/imageio_remove_bin'...
pytestcachePhase
/nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-10-26T12:03:12Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

/nix/store/sfnlxf8bk5m15pzd1qhy5zvhzcd0wbk2-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-10-26T12:03:16Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

/nix/store/jlqlmj58m55vm9c8jpmr7zjjq7dasm1f-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-10-26T12:33:02Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1/lib  /nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1/bin
patching script interpreter paths in /nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1
checking for references to /build in /nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1...
wrapping `/nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1/bin/imageio_download_bin'...
wrapping `/nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1/bin/imageio_remove_bin'...
pytestcachePhase
/nix/store/1kb1ihsbddffnrzqi6fg1ar1f6ix5rg6-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-10-26T12:33:04Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1/lib  /nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1/bin
patching script interpreter paths in /nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1
checking for references to /build in /nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1...
wrapping `/nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1/bin/imageio_remove_bin'...
wrapping `/nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1/bin/imageio_download_bin'...
pytestcachePhase
/nix/store/gyykd3cznrflddljqyqhkgglaaxxh10b-python3.6-imageio-2.4.1

dotlambda · 2018-10-27T13:05:04Z

# Tries to write in /var/tmp/.imageio
doCheck = false;

Maybe we can patch the tests to make them run? Or maybe it's sufficient to set some environment variable like $TMP.

pmiddend · 2018-10-27T16:06:30Z

@dotlambda It's a good point. I found out that setting IMAGEIO_USERDIR="$TMP" solves the problem, but then the tests begin downloading images from the web. Now, one might be able to download the images in the nix derivation, but...that seems a bit overkill, in my opinion.

pmiddend · 2018-10-29T12:08:52Z

I'm conversing with the author, let's keep the PR open until that's cleared up.

pmiddend · 2018-10-31T11:44:37Z

Okay, I've updated the build so the tests work. This can be merged now.

GrahamcOfBorg · 2018-10-31T12:01:20Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/rbm37a199q06x786xvjh0kp2lid0vjcm-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 37.30 seconds =========
pytestcachePhase
/nix/store/rbm37a199q06x786xvjh0kp2lid0vjcm-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-10-31T12:01:39Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/98kbqyhh0f1wrg48lkras7fpncvfkjaw-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 41.71 seconds =========
pytestcachePhase
/nix/store/98kbqyhh0f1wrg48lkras7fpncvfkjaw-python3.6-imageio-2.4.1

pkgs/development/python-modules/imageio/default.nix

pmiddend · 2018-11-02T14:09:22Z

@dotlambda I removed the patch and replaced with with a postPatch phase.

GrahamcOfBorg · 2018-11-02T14:24:07Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 37.29 seconds =========
pytestcachePhase
/nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-11-02T14:24:24Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 25.96 seconds =========
pytestcachePhase
/nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1

pkgs/development/python-modules/imageio/default.nix

pmiddend · 2018-11-03T21:46:29Z

@dotlambda Fixed the doCheck

GrahamcOfBorg · 2018-11-03T22:02:26Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

/nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-11-03T22:02:51Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 37.31 seconds =========
pytestcachePhase
/nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1

dotlambda · 2018-11-04T14:01:29Z

@GrahamcOfBorg build python2.pkgs.imageio python3.pkgs.imageio

GrahamcOfBorg · 2018-11-04T14:02:17Z

Failure on x86_64-darwin (full log)

Attempted: python2.pkgs.imageio, python3.pkgs.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/077iha76h2x7xxyzw2anm2fcyvbgikpk-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 19.98 seconds =========
pytestcachePhase
error: build of '/nix/store/kq1rx2miv93b8x3n1d2fiachj7rxbcp3-python2.7-imageio-2.4.1.drv' failed

GrahamcOfBorg · 2018-11-04T14:02:36Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.imageio, python3.pkgs.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 37.25 seconds =========
pytestcachePhase
error: build of '/nix/store/wl2y9g8vv65c2mkp0cdkyhq7qq4k4bhx-python2.7-imageio-2.4.1.drv' failed

GrahamcOfBorg · 2018-11-04T14:03:45Z

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.imageio, python3.pkgs.imageio

Partial log (click to expand)

    warnings.warn("%s%s" % (e, warn))

tests/test_pillow.py::test_png
  /nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 26.34 seconds =========
pytestcachePhase
error: build of '/nix/store/97mni974n1qa17y0rvznnv33wwn9pakx-python2.7-imageio-2.4.1.drv' failed

pmiddend · 2018-11-04T17:10:12Z

@dotlambda I fixed the failures with Python 2. Two more dependencies were needed.

GrahamcOfBorg · 2018-11-04T17:24:36Z

Success on aarch64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

/nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-11-04T17:25:10Z

Success on x86_64-linux (full log)

Attempted: python36Packages.imageio

Partial log (click to expand)

/nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1

dotlambda · 2018-11-04T17:29:49Z

@GrahamcOfBorg build python2.pkgs.imageio python3.pkgs.imageio

GrahamcOfBorg · 2018-11-04T17:30:57Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.imageio, python3.pkgs.imageio

Partial log (click to expand)


tests/test_pillow.py::test_png
  /nix/store/hgv4vl4l2m81d4wx1pw7jcrmfjx0h3jx-python2.7-imageio-2.4.1/lib/python2.7/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 35.68 seconds =========
pytestcachePhase
/nix/store/hgv4vl4l2m81d4wx1pw7jcrmfjx0h3jx-python2.7-imageio-2.4.1
/nix/store/5w6p7s9xvrd8akk3z40bbqwasfhqamv2-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-11-04T17:31:00Z

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.imageio, python3.pkgs.imageio

Partial log (click to expand)


tests/test_pillow.py::test_png
  /nix/store/077iha76h2x7xxyzw2anm2fcyvbgikpk-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 25.71 seconds =========
pytestcachePhase
/nix/store/q41fa6vb5kmsi7sn7kjnsmq142nf513y-python2.7-imageio-2.4.1
/nix/store/077iha76h2x7xxyzw2anm2fcyvbgikpk-python3.6-imageio-2.4.1

GrahamcOfBorg · 2018-11-04T17:31:51Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.imageio, python3.pkgs.imageio

Partial log (click to expand)


tests/test_pillow.py::test_png
  /nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1/lib/python3.6/site-packages/imageio/plugins/pillow.py:317: UserWarning: PIL PNG writer cannot produce interlaced images.
    warn("PIL PNG writer cannot produce interlaced images.")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======== 56 passed, 67 skipped, 3 xfailed, 5 warnings in 41.79 seconds =========
pytestcachePhase
/nix/store/mf4m78grgdf9ciz751i3x4h3giv8g4b7-python2.7-imageio-2.4.1
/nix/store/m019mqrfs0xhbrrr5dpscm32gdk2fcdf-python3.6-imageio-2.4.1

pmiddend requested a review from FRidh as a code owner October 26, 2018 11:47

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 26, 2018

pmiddend force-pushed the imageio-1.6_2.4.1 branch from bb2ded7 to 7816838 Compare October 26, 2018 12:21

pmiddend mentioned this pull request Oct 27, 2018

Don't make the tests depend on an active internet connection imageio/imageio#395

Closed

pmiddend force-pushed the imageio-1.6_2.4.1 branch from 7816838 to 07a4beb Compare October 31, 2018 11:42

pmiddend force-pushed the imageio-1.6_2.4.1 branch from 07a4beb to dc320e9 Compare October 31, 2018 11:47

dotlambda reviewed Oct 31, 2018

View reviewed changes

pkgs/development/python-modules/imageio/default.nix Outdated Show resolved Hide resolved

pmiddend force-pushed the imageio-1.6_2.4.1 branch from dc320e9 to 319d801 Compare November 2, 2018 14:08

dotlambda requested changes Nov 3, 2018

View reviewed changes

pkgs/development/python-modules/imageio/default.nix Outdated Show resolved Hide resolved

pmiddend force-pushed the imageio-1.6_2.4.1 branch from 319d801 to d77ca36 Compare November 3, 2018 21:45

dotlambda changed the title ~~python36Packages.imageio: 1.6 -> 2.4.1~~ pythonPackages.imageio: 1.6 -> 2.4.1 Nov 4, 2018

python36Packages.imageio: 1.6 -> 2.4.1

48daa12

pmiddend force-pushed the imageio-1.6_2.4.1 branch from d77ca36 to 48daa12 Compare November 4, 2018 17:09

dotlambda merged commit ef9b17b into NixOS:master Nov 4, 2018

pmiddend deleted the imageio-1.6_2.4.1 branch November 4, 2018 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.imageio: 1.6 -> 2.4.1 #49147

pythonPackages.imageio: 1.6 -> 2.4.1 #49147

pmiddend commented Oct 26, 2018

pmiddend commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

dotlambda commented Oct 27, 2018

pmiddend commented Oct 27, 2018

pmiddend commented Oct 29, 2018

pmiddend commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

pmiddend commented Nov 2, 2018

GrahamcOfBorg commented Nov 2, 2018

GrahamcOfBorg commented Nov 2, 2018

pmiddend commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

dotlambda commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

pmiddend commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

dotlambda commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

pythonPackages.imageio: 1.6 -> 2.4.1 #49147

pythonPackages.imageio: 1.6 -> 2.4.1 #49147

Conversation

pmiddend commented Oct 26, 2018

Motivation for this change

Things done

pmiddend commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

GrahamcOfBorg commented Oct 26, 2018

dotlambda commented Oct 27, 2018

pmiddend commented Oct 27, 2018

pmiddend commented Oct 29, 2018

pmiddend commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

GrahamcOfBorg commented Oct 31, 2018

pmiddend commented Nov 2, 2018

GrahamcOfBorg commented Nov 2, 2018

GrahamcOfBorg commented Nov 2, 2018

pmiddend commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

dotlambda commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

pmiddend commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

dotlambda commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018