Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: 1.29.1 -> 1.30.0 #49145

Merged
merged 3 commits into from Oct 26, 2018
Merged

rust: 1.29.1 -> 1.30.0 #49145

merged 3 commits into from Oct 26, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 26, 2018 •
edited

Motivation for this change

builds on x86_64 linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from LnL7 as a code owner October 26, 2018 09:38
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rustc

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/l2apy6cp27r7x62a54lk1v356fxk59ny-rustc-1.30.0-man
gzipping man pages under /nix/store/l2apy6cp27r7x62a54lk1v356fxk59ny-rustc-1.30.0-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/l2apy6cp27r7x62a54lk1v356fxk59ny-rustc-1.30.0-man
checking for references to /build in /nix/store/l2apy6cp27r7x62a54lk1v356fxk59ny-rustc-1.30.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/yignkx5sjcj6qjfhm5mqsk3x6vkprgva-rustc-1.30.0-doc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/yignkx5sjcj6qjfhm5mqsk3x6vkprgva-rustc-1.30.0-doc
checking for references to /build in /nix/store/yignkx5sjcj6qjfhm5mqsk3x6vkprgva-rustc-1.30.0-doc...
/nix/store/ichjgdq9pznhcbqpdw1b9wspq416bbgz-rustc-1.30.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rustc

Partial log (click to expand)

these derivations will be built:
  /nix/store/c6y5nyc90yyf6grcyp6basd2xz54afmy-rustc-1.30.0.drv
waiting for locks or build slots...
/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0

LnL7
LnL7 approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still building some other stuff, but rustc looks good.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: rustc

Partial log (click to expand)

   Compiling rustc_data_structures v0.0.0 (file:///build/rustc-1.30.0-src/src/librustc_data_structures)
   Compiling arena v0.0.0 (file:///build/rustc-1.30.0-src/src/libarena)
   Compiling syntax_pos v0.0.0 (file:///build/rustc-1.30.0-src/src/libsyntax_pos)
   Compiling rustc_errors v0.0.0 (file:///build/rustc-1.30.0-src/src/librustc_errors)
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.30.0-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.30.0-src/src/libsyntax_ext)
   Compiling rustc_metadata_utils v0.0.0 (file:///build/rustc-1.30.0-src/src/librustc_metadata_utils)
   Compiling rustc_typeck v0.0.0 (file:///build/rustc-1.30.0-src/src/librustc_typeck)
building of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' timed out after 3600 seconds
error: build of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Oct 26, 2018

aarch64-linux works!

@Mic92
Copy link
Member Author

Mic92 commented Oct 26, 2018

@LnL7 from my side everything looks good. You can merge it, when your other builds work.

@LnL7
Copy link
Member

LnL7 commented Oct 26, 2018

Looks like cargo failed, working on a fix.

@LnL7
cargo: fix darwin build
1b47b95 
It depends the Security framework now.
@LnL7
Copy link
Member

LnL7 commented Oct 26, 2018

Yeah, linux is fine.

andir
andir approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me on linux (x86-64)

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cargo, rustc

Partial log (click to expand)

/nix/store/v5g7why1d7vi5yl907caxh3rn65wc2rk-cargo-1.30.0
/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo, rustc

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/b6m5awq2vjfa430pwbj9pqz3gg8y5cnj-cargo-1.30.0
shrinking /nix/store/b6m5awq2vjfa430pwbj9pqz3gg8y5cnj-cargo-1.30.0/bin/.cargo-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b6m5awq2vjfa430pwbj9pqz3gg8y5cnj-cargo-1.30.0/bin
patching script interpreter paths in /nix/store/b6m5awq2vjfa430pwbj9pqz3gg8y5cnj-cargo-1.30.0
checking for references to /build in /nix/store/b6m5awq2vjfa430pwbj9pqz3gg8y5cnj-cargo-1.30.0...
/nix/store/b6m5awq2vjfa430pwbj9pqz3gg8y5cnj-cargo-1.30.0
/nix/store/ichjgdq9pznhcbqpdw1b9wspq416bbgz-rustc-1.30.0

@LnL7 LnL7 merged commit b6e1b2f into NixOS:master Oct 26, 2018
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: cargo, rustc

Partial log (click to expand)

[ 62%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMOptimizeBarriersPass.cpp.o
[ 62%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMRegisterBankInfo.cpp.o
[ 62%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RegisterCoalescer.cpp.o
[ 62%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMSelectionDAGInfo.cpp.o
[ 62%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMSubtarget.cpp.o
[ 62%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RegisterPressure.cpp.o
[ 62%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMTargetMachine.cpp.o
building of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/amvxhnkmn7szrbgp5k6zrd9nrms8i7cj-cargo-1.30.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/amvxhnkmn7szrbgp5k6zrd9nrms8i7cj-cargo-1.30.0.drv', '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' failed

@Mic92 Mic92 deleted the rustc branch October 27, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @LnL7 @andir