Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create readme.java #49136

Closed
wants to merge 1 commit into from
Closed

Create readme.java #49136

wants to merge 1 commit into from

Conversation

haseeAmarathunga
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 26, 2018

What is the purpose or the motivation behind this PR?

@edolstra
Copy link
Member

Looks like an accidental PR?

@edolstra edolstra closed this Oct 26, 2018
@grahamc
Copy link
Member

grahamc commented Oct 26, 2018

DigitalOcean's Hacktoberfest "inspires" PRs like this.

@jtakalai
Copy link

What is the purpose or the motivation behind this PR?

Isn't it described in full under "Motivation for this change"?

@haseeAmarathunga haseeAmarathunga deleted the patch-1 branch October 29, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
2.status: invalid 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@haseeAmarathunga @c0bw3b @edolstra @grahamc @jtakalai @dywedir @GrahamcOfBorg @Janik-Haag