wownero: init at 0.4.0.0 #49138

ghost · 2018-10-26T08:19:44Z

Motivation for this change

Add the cryptocurrency Wownero to nixpkgs.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

ghost · 2018-10-26T08:20:44Z

@jwinterm for review

ghost · 2018-10-29T00:42:30Z

updated the PR to point to the latest release

ghost · 2018-10-29T18:41:14Z

updated again to point to the latest release

kalbasit · 2018-11-08T07:35:42Z

pkgs/applications/altcoins/wownero.nix

+  name = "wownero-${version}";
+
+  version = "0.3.1.3";
+  src = fetchgit {


please use fetchFromGitHub instead of fetchgit

Thanks @kalbasit, i needed the fetchSubmodules = true; part from fetchgit, is it supported in fetchFromGithub now?

Yes it's supported, see the source for fetchFromGitHub here.

Thanks! updated.

kalbasit · 2018-11-08T07:37:23Z

pkgs/applications/altcoins/wownero.nix

+
+      Unlike opposing forks.
+    '';
+    homepage    = https://wownero.org/;


They don't respond to https, http://wownero.org/ works though.

Thanks, reported in the IRC, but it should be fixed soon.

url updated to use plain http.

infinisil · 2018-11-11T00:40:11Z

pkgs/applications/altcoins/wownero.nix

+
+      It’s not a fork of another blockchain. With its own genesis block there is no degradation of privacy caused by ring signatures using different participants for the same transaction outputs.
+
+      Unlike opposing forks.


Can you fix the formatting here? Only needs newlines to keep the length under 80 columns, no other newlines needed.

Thanks for the information, fixed.

infinisil · 2018-11-11T00:41:17Z

pkgs/applications/altcoins/wownero.nix

+  hardeningDisable = [ "fortify" ];
+
+  meta = {
+    description = "Many coins, such privacy. Wow!";


This isn't a very descriptive description.. Can you put something better here?

@jwinterm any suggestions?

I updated the description to use the first line of the long description, which happens to be the summary of it.

infinisil · 2018-11-11T00:41:45Z

maintainers/maintainer-list.nix

+    email = "echowss@gmail.com";
+    github = "fuwa0529";
+    name = "Haruka Akiyama";
+  };


Put this change into a separate commit in this PR.

infinisil · 2018-11-11T13:54:22Z

@GrahamcOfBorg build altcoins.wownero

GrahamcOfBorg · 2018-11-11T14:00:35Z

Success on aarch64-linux (full log)

Attempted: altcoins.wownero

Partial log (click to expand)

shrinking /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/bin/wownero-blockchain-import
shrinking /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/bin/wownerod
shrinking /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/bin/wownero-gen-trusted-multisig
shrinking /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/bin/wownero-wallet-cli
shrinking /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/bin/wownero-wallet-rpc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/lib  /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0/bin
patching script interpreter paths in /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0
checking for references to /build in /nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0...
/nix/store/520p3122v2gwxcvl0vapmdqq5g0r6z6h-wownero-0.4.0.0

GrahamcOfBorg · 2018-11-11T14:09:37Z

Success on x86_64-linux (full log)

Attempted: altcoins.wownero

Partial log (click to expand)

shrinking /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/bin/wownero-blockchain-import
shrinking /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/bin/wownerod
shrinking /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/bin/wownero-blockchain-export
shrinking /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/bin/wownero-wallet-cli
shrinking /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/bin/wownero-blockchain-blackball
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/lib  /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0/bin
patching script interpreter paths in /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0
checking for references to /build in /nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0...
/nix/store/2qw0bls21g1j6v6lsm9lwag1pv6pi4yn-wownero-0.4.0.0

GrahamcOfBorg · 2018-11-11T14:11:03Z

Success on x86_64-darwin (full log)

Attempted: altcoins.wownero

Partial log (click to expand)

-- Installing: /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/bin/wownerod
-- Installing: /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/bin/wownero-blockchain-import
-- Installing: /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/bin/wownero-blockchain-export
-- Installing: /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/bin/wownero-blockchain-blackball
-- Installing: /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/bin/wownero-blockchain-usage
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/lib  /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0/bin
patching script interpreter paths in /nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0
/nix/store/mjq3xrbxfvhjl0cn8269952n87ps683f-wownero-0.4.0.0

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 26, 2018

ghost changed the title ~~wownero: init at 0.3.0.0~~ wownero: init at 0.3.1.0 Oct 29, 2018

ghost changed the title ~~wownero: init at 0.3.1.0~~ wownero: init at 0.3.1.1 Oct 29, 2018

ghost changed the title ~~wownero: init at 0.3.1.1~~ wownero: init at 0.3.1.3 Nov 8, 2018

kalbasit requested changes Nov 8, 2018

View reviewed changes

ghost changed the title ~~wownero: init at 0.3.1.3~~ wownero: init at 0.4.0.0 Nov 9, 2018

infinisil requested changes Nov 11, 2018

View reviewed changes

fuwa added 2 commits November 11, 2018 14:56

maintainers: add fuwa

6c7ff0c

wownero: init at 0.4.0.0

931ebbc

infinisil approved these changes Nov 11, 2018

View reviewed changes

infinisil merged commit e2bae13 into NixOS:master Nov 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wownero: init at 0.4.0.0 #49138

wownero: init at 0.4.0.0 #49138

ghost commented Oct 26, 2018

ghost commented Oct 26, 2018

ghost commented Oct 29, 2018

ghost commented Oct 29, 2018

kalbasit Nov 8, 2018

ghost Nov 9, 2018 •

edited by ghost

kalbasit Nov 9, 2018 •

edited

ghost Nov 9, 2018

kalbasit Nov 8, 2018

ghost Nov 9, 2018

ghost Nov 9, 2018

infinisil Nov 11, 2018

ghost Nov 11, 2018

infinisil Nov 11, 2018

ghost Nov 11, 2018

ghost Nov 11, 2018

infinisil Nov 11, 2018

ghost Nov 11, 2018

infinisil commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018


		It’s not a fork of another blockchain. With its own genesis block there is no degradation of privacy caused by ring signatures using different participants for the same transaction outputs.

		Unlike opposing forks.

wownero: init at 0.4.0.0 #49138

wownero: init at 0.4.0.0 #49138

Conversation

ghost commented Oct 26, 2018

Motivation for this change

Things done

ghost commented Oct 26, 2018

ghost commented Oct 29, 2018

ghost commented Oct 29, 2018

Choose a reason for hiding this comment

ghost Nov 9, 2018 • edited by ghost

Choose a reason for hiding this comment

kalbasit Nov 9, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

infinisil commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

ghost Nov 9, 2018 •

edited by ghost

kalbasit Nov 9, 2018 •

edited