Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/trezord: revised and updated udev rules #49152

Merged
merged 1 commit into from Oct 26, 2018
Merged

nixos/trezord: revised and updated udev rules #49152

merged 1 commit into from Oct 26, 2018

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Oct 26, 2018

Motivation for this change

Trezord devices should be run under a separate user/group (dialout->trezord) without others able to access the device (666->660).

Things done

Applied more restrictive policies (improved security), replaced generic dialout group with trezord group. Tested with both Trezor One and Trezor Model T.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@1000101
Copy link
Member Author

1000101 commented Oct 26, 2018

@roconnor-blockstream would you like to review this and backport PR(s)?
#49156
#49157

@infinisil
Copy link
Member

This technically can break people's configs (them having relied on the old group), but there's probably very few if any affected by this.

@infinisil infinisil merged commit 932e27c into NixOS:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants