Add pre-commit and its dependencies #49163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit is "a framework for managing and maintaining multi-language pre-commit hooks". More info here: https://pre-commit.com
worldofpeace
suggested changes
Oct 26, 2018
There was a problem hiding this comment.
Please split up these changes into multiple commits.
Precisely like:
- add yourself to the maintainers list
maintainers: add name
- one each for package initialization
pkg-name: init at version
Also preferably with its dependents preceding pre-commit.
More can be seen in CONTRIBUTING.md
dotlambda
requested changes
Oct 27, 2018
| buildPythonPackage rec { | ||
| pname = "importlib_metadata"; | ||
| version = "0.6"; | ||
| name = "importlib_metadata"; |
| sha256 = "074v6mq5dbbr0y697fgajm503sg83faxzvwz41jxy6h0z622rc1n"; | ||
| }; | ||
|
|
||
| pythonPath = [ recursivePthLoader ]; |
There was a problem hiding this comment.
Why is this needed? Why don't you use propagatedBuildInputs or nativeBuildInputs?
|
|
||
| pythonPath = [ recursivePthLoader ]; | ||
|
|
||
| doCheck = false; |
| pythonPath = [ recursivePthLoader ]; | ||
|
|
||
| doCheck = false; | ||
| propagatedBuildInputs = [ ]; |
| buildPythonPackage rec { | ||
| pname = "importlib_resources"; | ||
| version = "1.0.1"; | ||
| name = "importlib_resources"; |
| ''; | ||
|
|
||
| meta = { | ||
| description = "A framework for managing and maintaining multi-language pre-commit hooks."; |
There was a problem hiding this comment.
| importlib-metadata = callPackage ../development/python-modules/importlib-metadata { }; | ||
| importlib-resources = callPackage ../development/python-modules/importlib-resources { }; | ||
| setuptools-markdown = callPackage ../development/python-modules/setuptools-markdown { }; | ||
| pre-commit = callPackage ../development/python-modules/pre-commit { }; |
There was a problem hiding this comment.
This file should be sorted alphabetically.
|
|
||
| propagatedBuildInputs = [ pypandoc ]; | ||
| pythonPath = [ recursivePthLoader ]; | ||
| doCheck = false; |
| buildPythonPackage rec { | ||
| pname = "setuptools-markdown"; | ||
| version = "0.2"; | ||
| name = "setuptools_markdown"; |
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "setuptools-markdown"; |
There was a problem hiding this comment.
Are you sure that this works? Pypandoc is broken.
|
I only found out after reviewing that this package already exists: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/version-management/git-and-tools/pre-commit/default.nix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit is "a framework for managing and maintaining multi-language
pre-commit hooks". More info here: https://pre-commit.com
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)