Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono: Unbreak on aarch64 #49164

Merged
merged 1 commit into from Oct 26, 2018
Merged

mono: Unbreak on aarch64 #49164

merged 1 commit into from Oct 26, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 26, 2018 •
edited

Motivation for this change

Mono seems to work fine on aarch64 (at least mono58).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member Author

adisbladis commented Oct 26, 2018 •
edited

cc @xeji @thoughtpolice @obadz @vrthra

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mono

Partial log (click to expand)

/nix/store/qw0x14xyhj9gbl1idfz54i6xfk09lc0a-mono-5.8.0.108

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mono

Partial log (click to expand)

these paths will be fetched (114.02 MiB download, 434.46 MiB unpacked):
  /nix/store/hska1hhbxhpxvwpyas4g9yjj8019s864-libgdiplus-2.10.9
  /nix/store/sx8h2w1hfgbs542fhr3a3pmk1yrzb1kx-mono-5.8.0.108
copying path '/nix/store/hska1hhbxhpxvwpyas4g9yjj8019s864-libgdiplus-2.10.9' from 'https://cache.nixos.org'...
copying path '/nix/store/sx8h2w1hfgbs542fhr3a3pmk1yrzb1kx-mono-5.8.0.108' from 'https://cache.nixos.org'...
/nix/store/sx8h2w1hfgbs542fhr3a3pmk1yrzb1kx-mono-5.8.0.108

@xeji
Copy link
Contributor

xeji commented Oct 26, 2018

The same mono version was indeed broken at that time https://hydra.nixos.org/job/nixpkgs/trunk/mono.aarch64-linux but if it's fine now, great!

@xeji xeji merged commit 80dd2fa into NixOS:master Oct 26, 2018
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: mono

Partial log (click to expand)

xmltool.cs(181,4): warning CS0618: 'XmlSchema.Compile(ValidationEventHandler)' is obsolete: 'Use System.Xml.Schema.XmlSchemaSet for schema compilation and validation. http://go.microsoft.com/fwlink/?linkid=14202'
xmltool.cs(184,5): warning CS0618: 'XmlValidatingReader' is obsolete: 'Use XmlReader created by XmlReader.Create() method using appropriate XmlReaderSettings instead. http://go.microsoft.com/fwlink/?linkid=14202'
xmltool.cs(184,35): warning CS0618: 'XmlValidatingReader' is obsolete: 'Use XmlReader created by XmlReader.Create() method using appropriate XmlReaderSettings instead. http://go.microsoft.com/fwlink/?linkid=14202'
xmltool.cs(208,5): warning CS0618: 'XmlValidatingReader' is obsolete: 'Use XmlReader created by XmlReader.Create() method using appropriate XmlReaderSettings instead. http://go.microsoft.com/fwlink/?linkid=14202'
xmltool.cs(208,35): warning CS0618: 'XmlValidatingReader' is obsolete: 'Use XmlReader created by XmlReader.Create() method using appropriate XmlReaderSettings instead. http://go.microsoft.com/fwlink/?linkid=14202'
xmltool.cs(220,4): warning CS0618: 'XslTransform' is obsolete: 'This class has been deprecated. Please use System.Xml.Xsl.XslCompiledTransform instead. http://go.microsoft.com/fwlink/?linkid=14202'
xmltool.cs(220,25): warning CS0618: 'XslTransform' is obsolete: 'This class has been deprecated. Please use System.Xml.Xsl.XslCompiledTransform instead. http://go.microsoft.com/fwlink/?linkid=14202'
CSC     [net_4_x-darwin] mono-shlib-cop.exe
building of '/nix/store/l8xvdmn71i0a3ay6xds30b8ydld4yw7m-mono-5.8.0.108.drv' timed out after 1800 seconds
error: build of '/nix/store/l8xvdmn71i0a3ay6xds30b8ydld4yw7m-mono-5.8.0.108.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @GrahamcOfBorg @xeji