Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] python.pkgs.construct: 2.8.16 -> 2.9.45 #49155

Closed
wants to merge 1 commit into from
Closed

[18.09] python.pkgs.construct: 2.8.16 -> 2.9.45 #49155

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 26, 2018 •
edited

(cherry picked from commit d117e3c)

Motivation for this change

This should have been cherry-picked into 18.09 imho.

Construct 2.9 was released in January 2018 and brings a couple of neat improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from FRidh as a code owner October 26, 2018 14:11
@prusnak prusnak changed the title python.pkgs.construct: 2.8.16 -> 2.9.45 [18.09] python.pkgs.construct: 2.8.16 -> 2.9.45 Oct 26, 2018
@dotlambda
Copy link
Member

This update seems to not be backwards-compatible: https://construct.readthedocs.io/en/latest/transition29.html
Please use the appropriate package from the unstable channel.

@dotlambda dotlambda closed this Oct 29, 2018
@prusnak prusnak deleted the backport-python-construct branch October 29, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @dotlambda @GrahamcOfBorg @rnhmjoj