Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] nixos/trezord: revised and updated udev rules #49157

Merged
merged 1 commit into from Oct 27, 2018
Merged

[18.03] nixos/trezord: revised and updated udev rules #49157

merged 1 commit into from Oct 27, 2018

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Oct 26, 2018

(cherry picked from commit a88e0ef)

Motivation for this change

Applied more restrictive policies (improved security), replaced generic dialout group with trezord group. Tested with both Trezor One and Trezor Model T.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@1000101 1000101 changed the title nixos/trezord: revised and updated udev rules [18.03] nixos/trezord: revised and updated udev rules Oct 26, 2018
@1000101 1000101 mentioned this pull request Oct 26, 2018
Merged
9 tasks
@infinisil
Copy link
Member

18.03 won't be updated anymore

@infinisil infinisil closed this Oct 26, 2018
@infinisil
Copy link
Member

Well apparently there are still some backports happening to 18.03, not sure why, should have stopped since 18.09 was released, #49187 (comment)

@infinisil infinisil reopened this Oct 27, 2018
@infinisil infinisil merged commit 6f07d27 into NixOS:release-18.03 Oct 27, 2018
@infinisil
Copy link
Member

I guess we're still doing backports to 18.03 :)

@1000101
Copy link
Member Author

1000101 commented Oct 27, 2018

I guess we're still doing backports to 18.03 :)

I thought so :). Thanks!.

@1000101 1000101 deleted the backport-release-18.03 branch November 6, 2018 14:50
@worldofpeace worldofpeace mentioned this pull request Nov 10, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1000101 @infinisil @GrahamcOfBorg