Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbsd: fix build w/musl by adding missing include #48355

Merged
merged 1 commit into from Oct 14, 2018
Merged

libbsd: fix build w/musl by adding missing include #48355

merged 1 commit into from Oct 14, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 14, 2018

Patch from void, with prefix added.

cc #48344

Recent update broke build w/musl,
but happily fixing it is the easy patch in this PR.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
libbsd: fix build w/musl by adding missing include
e2f8d7b 
Patch from void, with prefix added.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libbsd

Partial log (click to expand)

/nix/store/fqkq3is8wrbksaq3cq237kq50bn3fk6h-libbsd-0.9.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libbsd

Partial log (click to expand)

/nix/store/j0ayqbz2fqlbp5iwsb7pcwdfx326kb78-libbsd-0.9.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libbsd

Partial log (click to expand)

make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-libbsd-0.9.1.drv-0/libbsd-0.9.1'
make[1]: Leaving directory '/private/tmp/nix-build-libbsd-0.9.1.drv-0/libbsd-0.9.1'
post-installation fixup
gzipping man pages under /nix/store/lk178r7gj0y59x5i7lha74ia1inzida3-libbsd-0.9.1/share/man/
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lk178r7gj0y59x5i7lha74ia1inzida3-libbsd-0.9.1/lib
patching script interpreter paths in /nix/store/lk178r7gj0y59x5i7lha74ia1inzida3-libbsd-0.9.1
/nix/store/lk178r7gj0y59x5i7lha74ia1inzida3-libbsd-0.9.1

@dtzWill dtzWill merged commit 7f3f1fd into NixOS:master Oct 14, 2018
@dtzWill dtzWill deleted the fix/libbsd-musl-again branch October 14, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg