openjdk: 10.0.2 -> 11.0.1 #48326

jerith666 · 2018-10-13T17:27:03Z

Major TODOs:

JRE is deprecated, they recommend using jmod
ARM doesn't build openjdk but uses oraclejdk
- ~~get them building~~
  - ~~need bootstrap jdk for ARM~~
- ~~update oraclejdk to 11 too~~
- realize that 10 wasn't working on ARM anyway (jdk10: remove special handling for arm #48649)
Consider reusing some of the AdoptOpenJDK build scripts? https://github.com/AdoptOpenJDK/openjdk-build
Update darwin

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

jerith666 · 2018-10-18T01:14:09Z

We'll need a bootstrap jdk for arm before we can build openjdk for that architecture.

jerith666 · 2018-10-25T22:31:41Z

Squashed some of my WIP comments ... I think I need someone who has access to darwin to make that update, though?

uri-canva · 2018-10-26T22:12:22Z

pkgs/top-level/all-packages.nix

@@ -8098,10 +8095,10 @@ with pkgs;
    inherit (darwin) cctools;
    inherit (darwin.apple_sdk.frameworks) CoreFoundation CoreServices Foundation;
  };
-  bazel_jdk10 = callPackage ../development/tools/build-managers/bazel {
+  bazel_jdk11 = callPackage ../development/tools/build-managers/bazel {


jerith666 · 2018-10-28T18:37:55Z

Okay, I've tested that eclipse runs with jdk11 locally. I think once someone can confirm that the darwin jdk11 is basically working, this is ready to merge!

uri-canva · 2018-10-29T00:11:50Z

Tested this to use Bazel with jdk11 on darwin, failed:

these derivations will be built:
  /nix/store/0vw2fndb535kqj1bbfp42h26zy5pxjv6-zulu11.2.3-jdk11.0.1-linux_x64.tar.gz.drv
  /nix/store/d7bq5ir7mxhs87h0zy88daa1g5glkyjl-zulu11.2.3-jdk11.0.1.drv
  /nix/store/3fb0mnlp8b680ywdl3gvggs02vzcn3py-bazel-0.17.1.drv
these paths will be fetched (73.15 MiB download, 76.57 MiB unpacked):
  /nix/store/08hdv1dsr6ngmyq47h25nqcg3k4fdfmb-bazel-deps
  /nix/store/rd9bdnf17wsfqclyqz4gv3gfb58nfsx8-bazel-0.17.1-dist.zip
  /nix/store/xfc7wancf1x9m0qnc319dfkq1l9viq49-27be70979b54d7510bf401d9581fb4075737ef34.patch
copying path '/nix/store/xfc7wancf1x9m0qnc319dfkq1l9viq49-27be70979b54d7510bf401d9581fb4075737ef34.patch' from 'https://cache.nixos.org'...
copying path '/nix/store/rd9bdnf17wsfqclyqz4gv3gfb58nfsx8-bazel-0.17.1-dist.zip' from 'https://cache.nixos.org'...
copying path '/nix/store/08hdv1dsr6ngmyq47h25nqcg3k4fdfmb-bazel-deps' from 'https://cache.nixos.org'...
building '/nix/store/0vw2fndb535kqj1bbfp42h26zy5pxjv6-zulu11.2.3-jdk11.0.1-linux_x64.tar.gz.drv'...

trying https://cdn.azul.com/zulu/bin/zulu11.2.3-jdk11.0.1-linux_x64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  187M  100  187M    0     0  5955k      0  0:00:32  0:00:32 --:--:-- 8910k
building '/nix/store/d7bq5ir7mxhs87h0zy88daa1g5glkyjl-zulu11.2.3-jdk11.0.1.drv'...
unpacking sources
unpacking source archive /nix/store/az6zgzvxqs53ns9pvd8bmhcjc68plrhy-zulu11.2.3-jdk11.0.1-linux_x64.tar.gz
source root is zulu11.2.3-jdk11.0.1-linux_x64
setting SOURCE_DATE_EPOCH to timestamp 1539936296 of file zulu11.2.3-jdk11.0.1-linux_x64/readme.txt
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
Archive:  /nix/store/xkf1p54gf3igqr3qvwxgrrk4asfxl4qp-ZuluJCEPolicies.zip
   creating: ZuluJCEPolicies/
  inflating: ZuluJCEPolicies/LICENSE
  inflating: ZuluJCEPolicies/README.txt
  inflating: ZuluJCEPolicies/DISCLAIMER
  inflating: ZuluJCEPolicies/local_policy.jar
  inflating: ZuluJCEPolicies/US_export_policy.jar
post-installation fixup
error: install_name_tool: can't open file: /nix/store/knc10wvsrgca7schl7d6hpplhvrsbwg4-zulu11.2.3-jdk11.0.1/lib/libfontmanager.dylib (No such file or directory)
builder for '/nix/store/d7bq5ir7mxhs87h0zy88daa1g5glkyjl-zulu11.2.3-jdk11.0.1.drv' failed with exit code 1
error: build of '/nix/store/3fb0mnlp8b680ywdl3gvggs02vzcn3py-bazel-0.17.1.drv', '/nix/store/d7bq5ir7mxhs87h0zy88daa1g5glkyjl-zulu11.2.3-jdk11.0.1.drv' failed

It seems like it's using the Linux derivation here:

$ ls -l /nix/store/knc10wvsrgca7schl7d6hpplhvrsbwg4-zulu11.2.3-jdk11.0.1/lib/
total 410608
-rw-r--r--  1 uri  staff      39427 19 Oct 18:55 classlist
-rw-r--r--  1 uri  staff    4489118 19 Oct 18:55 ct.sym
-rwxr-xr-x  1 uri  staff       9863 19 Oct 18:55 jexec
drwxr-xr-x  4 uri  staff        128 19 Oct 18:55 jfr
drwxr-xr-x  3 uri  staff         96 19 Oct 19:07 jli
-rw-r--r--  1 uri  staff     106630 19 Oct 18:55 jrt-fs.jar
-rw-r--r--  1 uri  staff         29 19 Oct 18:55 jvm.cfg
-rw-r--r--  1 uri  staff      12769 19 Oct 18:55 libattach.so
-rw-r--r--  1 uri  staff     761905 19 Oct 18:55 libawt.so
-rw-r--r--  1 uri  staff      42709 19 Oct 18:55 libawt_headless.so
-rw-r--r--  1 uri  staff     490199 19 Oct 18:55 libawt_xawt.so
-rw-r--r--  1 uri  staff      25443 19 Oct 18:55 libdt_socket.so
-rw-r--r--  1 uri  staff      11432 19 Oct 18:55 libextnet.so
-rw-r--r--  1 uri  staff     842211 19 Oct 18:55 libfontmanager.so
-rw-r--r--  1 uri  staff     772361 19 Oct 18:55 libfreetype.so
-rw-r--r--  1 uri  staff      49510 19 Oct 18:55 libinstrument.so
-rw-r--r--  1 uri  staff      46995 19 Oct 18:55 libj2gss.so
-rw-r--r--  1 uri  staff      15994 19 Oct 18:55 libj2pcsc.so
-rw-r--r--  1 uri  staff      80337 19 Oct 18:55 libj2pkcs11.so
-rw-r--r--  1 uri  staff       8170 19 Oct 18:55 libjaas.so
-rw-r--r--  1 uri  staff     225489 19 Oct 18:55 libjava.so
-rw-r--r--  1 uri  staff     247117 19 Oct 18:55 libjavajpeg.so
-rw-r--r--  1 uri  staff       7803 19 Oct 18:55 libjawt.so
-rw-r--r--  1 uri  staff     276208 19 Oct 18:55 libjdwp.so
-rw-r--r--  1 uri  staff     135284 19 Oct 18:55 libjimage.so
-rw-r--r--  1 uri  staff      14366 19 Oct 18:55 libjsig.so
-rw-r--r--  1 uri  staff      82128 19 Oct 18:55 libjsound.so
-rw-r--r--  1 uri  staff     505031 19 Oct 18:55 liblcms.so
-rw-r--r--  1 uri  staff      25895 19 Oct 18:55 libmanagement.so
-rw-r--r--  1 uri  staff       7751 19 Oct 18:55 libmanagement_agent.so
-rw-r--r--  1 uri  staff      30570 19 Oct 18:55 libmanagement_ext.so
-rw-r--r--  1 uri  staff     531075 19 Oct 18:55 libmlib_image.so
-rw-r--r--  1 uri  staff     113129 19 Oct 18:55 libnet.so
-rw-r--r--  1 uri  staff      86553 19 Oct 18:55 libnio.so
-rw-r--r--  1 uri  staff       9283 19 Oct 18:55 libprefs.so
-rw-r--r--  1 uri  staff       6781 19 Oct 18:55 librmi.so
-rw-r--r--  1 uri  staff      58795 19 Oct 18:55 libsaproc.so
-rw-r--r--  1 uri  staff      28671 19 Oct 18:55 libsctp.so
-rw-r--r--  1 uri  staff     370420 19 Oct 18:55 libsplashscreen.so
-rw-r--r--  1 uri  staff     318147 19 Oct 18:55 libsunec.so
-rw-r--r--  1 uri  staff     217017 19 Oct 18:55 libunpack.so
-rw-r--r--  1 uri  staff      64725 19 Oct 18:55 libverify.so
-rw-r--r--  1 uri  staff      37209 19 Oct 18:55 libzip.so
-rw-r--r--  1 uri  staff  140987885 19 Oct 18:55 modules
-rw-r--r--  1 uri  staff       3793 19 Oct 18:55 psfont.properties.ja
-rw-r--r--  1 uri  staff      11390 19 Oct 18:55 psfontj2d.properties
drwxr-xr-x  8 uri  staff        256 29 Oct 11:01 security
drwxr-xr-x  5 uri  staff        160 19 Oct 19:07 server
-rw-r--r--  1 uri  staff   57825731 19 Oct 18:55 src.zip
-rw-r--r--  1 uri  staff     105882 19 Oct 18:55 tzdb.dat

They're Linux shared libraries:

$ file /nix/store/knc10wvsrgca7schl7d6hpplhvrsbwg4-zulu11.2.3-jdk11.0.1/lib/libfontmanager.so
/nix/store/knc10wvsrgca7schl7d6hpplhvrsbwg4-zulu11.2.3-jdk11.0.1/lib/libfontmanager.so: ELF 64-bit LSB shared object x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=79c4d8cf0e7d1dd5c0dbc745bda6b4b70256dc9a, not stripped

As opposed to Darwin shared libraries:

$ file /usr/lib/libSystem.dylib
/usr/lib/libSystem.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [i386:Mach-O dynamically linked shared library i386]
/usr/lib/libSystem.dylib (for architecture x86_64):     Mach-O 64-bit dynamically linked shared library x86_64
/usr/lib/libSystem.dylib (for architecture i386):       Mach-O dynamically linked shared library i386

* the jre is no longer an official part of the jdk (jmod is recommended as a replacement when needing to create smaller runtime images) * darwin continues to use zulu from azul * apps that used 10 now use 11 (eclipse, bazel, josm)

jerith666 · 2018-10-29T00:37:49Z

Oh geeze -- facepalm! I just followed the Referer:https://www.azul.com/downloads/zulu/zulu-linux/ link, which points to linux, and cut-n-pasted away. :(

Fixed in 1bd7b98, please try again!

uri-canva · 2018-10-29T00:51:24Z

All good, bazel_jdk11 builds and runs correctly with 1bd7b98c7975136ddd6183a155e90688fd5b3e43. I wasn't able to test building java 11 code with it because your branch doesn't have bazel-0.18.0 from current master, but only bazel-0.17.1 from an older point, but I think it should be ok as far as the jdk is concerned.

jerith666 · 2018-10-29T01:27:27Z

Awesome, thank you! Removed "WIP" from title, ready to merge now! :)

fpletz

LGTM

jerith666 mentioned this pull request Oct 13, 2018

oraclejdk: remove version 10 #47375

Merged

9 tasks

jerith666 force-pushed the jdk11 branch from db9e121 to f78fb17 Compare October 18, 2018 01:07

jdk: give more detail when bootstrap jdks are missing

8b5a759

jerith666 force-pushed the jdk11 branch from 0ed3a7e to 98e9136 Compare October 25, 2018 22:30

uri-canva reviewed Oct 26, 2018

View reviewed changes

jerith666 force-pushed the jdk11 branch 4 times, most recently from 1ba17e9 to 1d35fa5 Compare October 28, 2018 02:36

GrahamcOfBorg added 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Oct 28, 2018

openjdk: 10.0.2 -> 11.0.1

1bd7b98

* the jre is no longer an official part of the jdk (jmod is recommended as a replacement when needing to create smaller runtime images) * darwin continues to use zulu from azul * apps that used 10 now use 11 (eclipse, bazel, josm)

jerith666 force-pushed the jdk11 branch from 1d35fa5 to 1bd7b98 Compare October 29, 2018 00:36

jerith666 changed the title ~~WIP: openjdk: 10.0.2 -> 11~~ openjdk: 10.0.2 -> 11.0.1 Oct 29, 2018

fpletz approved these changes Nov 1, 2018

View reviewed changes

fpletz merged commit 38db6fd into NixOS:master Nov 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openjdk: 10.0.2 -> 11.0.1 #48326

openjdk: 10.0.2 -> 11.0.1 #48326

jerith666 commented Oct 13, 2018 •

edited

jerith666 commented Oct 18, 2018

jerith666 commented Oct 25, 2018

uri-canva Oct 26, 2018

jerith666 commented Oct 28, 2018

uri-canva commented Oct 29, 2018

jerith666 commented Oct 29, 2018

uri-canva commented Oct 29, 2018

jerith666 commented Oct 29, 2018

fpletz left a comment

openjdk: 10.0.2 -> 11.0.1 #48326

openjdk: 10.0.2 -> 11.0.1 #48326

Conversation

jerith666 commented Oct 13, 2018 • edited

Major TODOs:

Things done

jerith666 commented Oct 18, 2018

jerith666 commented Oct 25, 2018

uri-canva Oct 26, 2018

Choose a reason for hiding this comment

jerith666 commented Oct 28, 2018

uri-canva commented Oct 29, 2018

jerith666 commented Oct 29, 2018

uri-canva commented Oct 29, 2018

jerith666 commented Oct 29, 2018

fpletz left a comment

Choose a reason for hiding this comment

jerith666 commented Oct 13, 2018 •

edited