New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: init at 5.2.1 #48428
fmt: init at 5.2.1 #48428
Conversation
{ stdenv, fetchurl, cmake }: | ||
|
||
let | ||
version = "5.2.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put this variable in the derivation itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
|
||
stdenv.mkDerivation rec { | ||
name = "fmt-${version}"; | ||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to use fetchFromGithub (it only downloads a tar file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
sha256 = "3c812a18e9f72a88631ab4732a97ce9ef5bcbefb3235e9fd465f059ba204359b"; | ||
}; | ||
nativeBuildInputs = [ cmake ]; | ||
cmakeFlags = [ "-DFMT_TEST=no" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why tests have to be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks were failing due to the tests not finding the shared object. Changed that by setting LD_LIBRARY_PATH in the preCheckHook. If this problem is normally solved otherwise, please let me know.
cmakeFlags = [ "-DFMT_TEST=no" | ||
"-DBUILD_SHARED_LIBS=TRUE" ]; | ||
meta = with stdenv.lib; { | ||
homepage = "http://fmtlib.net/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Url doesn't need to be quoted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
This commit adds fmt, a C++ formatting library.
This commit adds fmt, a C++ formatting library.
Motivation for this change
fmt is an actively developed C++ formatting library. This derivation provides a shared library by default, but can be overridden to produce a static version.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)