Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][18.09] fwupd: Fix daemon config not being found #48430

Closed
wants to merge 1 commit into from
Closed

[WIP][18.09] fwupd: Fix daemon config not being found #48430

wants to merge 1 commit into from

Conversation

infinisil
Copy link
Member

Backport of #48427

(cherry picked from commit d720e9cd7cc9bbdece9442c6676e83e05d4c89b9)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill @infinisil
fwupd: fixup fu-config's attempt to find daemon.conf
dd8fcc3 
(cherry picked from commit d720e9cd7cc9bbdece9442c6676e83e05d4c89b9)
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fwupd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/xkrmvvbky2xzmkxf0whypkvplqpfsdyz-fwupd-1.1.1-installedTests
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xkrmvvbky2xzmkxf0whypkvplqpfsdyz-fwupd-1.1.1-installedTests
checking for references to /build in /nix/store/xkrmvvbky2xzmkxf0whypkvplqpfsdyz-fwupd-1.1.1-installedTests...
Wrapping program /nix/store/8kr8sy337m9xd9d1vxvz7r2y6gnbf65x-fwupd-1.1.1/bin/fwupdmgr
Wrapping program /nix/store/8kr8sy337m9xd9d1vxvz7r2y6gnbf65x-fwupd-1.1.1/bin/dfu-tool
Wrapping program /nix/store/8kr8sy337m9xd9d1vxvz7r2y6gnbf65x-fwupd-1.1.1/libexec/fwupd/fwupd
Wrapping program /nix/store/8kr8sy337m9xd9d1vxvz7r2y6gnbf65x-fwupd-1.1.1/libexec/fwupd/fwupdate
Wrapping program /nix/store/8kr8sy337m9xd9d1vxvz7r2y6gnbf65x-fwupd-1.1.1/libexec/fwupd/fwupdtool
/nix/store/8kr8sy337m9xd9d1vxvz7r2y6gnbf65x-fwupd-1.1.1

@samueldr
Copy link
Member

Does this PR need to be updated? Looking at the linked PR this backports, it looks like this doesn't match.

@infinisil
Copy link
Member Author

@samueldr Yeah, I'll update this PR after the non-backport one is merged

@samueldr samueldr changed the title [18.09] fwupd: Fix daemon config not being found [WIP][18.09] fwupd: Fix daemon config not being found Oct 20, 2018
@infinisil infinisil closed this Dec 23, 2018
@infinisil infinisil deleted the backport/fix/fwupd branch December 23, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infinisil @GrahamcOfBorg @samueldr @dtzWill