Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eclipse: add Eclipse IDE for Java Developers 4.7 and 4.8 #48395

Closed
wants to merge 2 commits into from
Closed

eclipse: add Eclipse IDE for Java Developers 4.7 and 4.8 #48395

wants to merge 2 commits into from

Conversation

joakim1999
Copy link
Contributor

@joakim1999 joakim1999 commented Oct 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

rycee
rycee reviewed Oct 14, 2018
View reviewed changes
pkgs/applications/editors/eclipse/default.nix Outdated

### Eclipse Java

eclipse-java-47 = buildEclipse {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new package and there is no concern about accommodating people preferring to stay on an older version I think we can remove the 4.7 version here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

rycee
rycee reviewed Oct 14, 2018
View reviewed changes
pkgs/applications/editors/eclipse/default.nix Outdated
else throw "Unsupported system: ${stdenv.system}";
};

eclipse-java-48 = buildEclipse {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add an eclipse-java = eclipse-java-48; entry for people that always want the latest version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, isn't the 2018-09 release called 4.9.0? If so then the package and attribute names should be updated to match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how i missed that. I am gonna fix that and also gonna make an eclipse-java entry for latest version.

rycee
rycee reviewed Oct 14, 2018
View reviewed changes
pkgs/applications/editors/eclipse/default.nix Outdated

eclipse-java-48 = buildEclipse {
name = "eclipse-java-4.8.0";
description = "Eclipse IDE for Java Developers, Oxygen release";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the ", Oxygen release" part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to change it to Photon release. But it's ok if i just don't say anything about the release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that should be fine. Alternatively, if you want, then put

description = "Eclipse IDE for Java Developers 2018-09"

similar to eclipse-platform-49 and eclipse-sdk-49.

@rycee
Copy link
Member

rycee commented Oct 14, 2018

Thanks for the contribution! Looks good overall, I just added a few minor comments.

@joakim1999
eclipse: fixed incorrect version
d767a34 
Changed entry eclipse-java-48 to eclipse-java-49 to match the files represented inside the entry.
Added eclipse-java entry pointing to latest version (eclipse-java-49)
@rycee
Copy link
Member

rycee commented Oct 15, 2018

@GrahamcOfBorg build eclipses.eclipse-java

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: eclipses.eclipse-java

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eclipses.eclipse-java

Partial log (click to expand)

eclipse/readme/
eclipse/readme/readme_eclipse.html
eclipse/dropins/
eclipse/eclipse.ini
eclipse/configuration/
eclipse/configuration/org.eclipse.equinox.simpleconfigurator/
eclipse/configuration/org.eclipse.equinox.simpleconfigurator/bundles.info
eclipse/configuration/config.ini
eclipse/configuration/org.eclipse.update/
eclipse/configuration/org.eclipse.update/platform.xml

@rycee
Copy link
Member

rycee commented Oct 15, 2018

Squashed and rebased to master in 6fe0f07. Thanks!

@rycee rycee closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joakim1999 @rycee @GrahamcOfBorg