adoptopenjdk-bin: init at 11 #48322
Merged
adoptopenjdk-bin: init at 11 #48322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/licenses.nix
Outdated
| @@ -309,6 +309,12 @@ lib.mapAttrs (n: v: v // { shortName = n; }) rec { | |||
| fullName = "GNU General Public License v2.0 only"; | |||
| }; | |||
|
|
|||
| gpl2Classpath = { | |||
| spdxId = "GPL-2.0 WITH Classpath-exception-2.0"; | |||
There was a problem hiding this comment.
Identifier should be GPL-2.0-with-classpath-exception
taku0
force-pushed
the
adoptopenjdk-bin-11+28
branch
from
d484614
to
1cd3b26
Compare
taku0
force-pushed
the
adoptopenjdk-bin-11+28
branch
from
1cd3b26
to
c89fb4a
Compare
|
Added Darwin packages. |
c0bw3b
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Green on nixos-18.09
Result in /[...]/nox-review-7i4pr45u
total 0
lrwxrwxrwx 1 zzzz users 71 24 oct. 18:46 result -> /nix/store/dl1psv9krb2ma1pl5y7s8ll41w3fwbwq-adoptopenjdk-hotspot-bin-11
lrwxrwxrwx 1 zzzz users 75 24 oct. 18:46 result-2 -> /nix/store/md4fhdpizm40lqps9501p06kxj4714y3-adoptopenjdk-jre-hotspot-bin-11
lrwxrwxrwx 1 zzzz users 74 24 oct. 18:46 result-3 -> /nix/store/vijvm03n69sfb0g4p3ms7smpg45lp359-adoptopenjdk-jre-openj9-bin-11
lrwxrwxrwx 1 zzzz users 70 24 oct. 18:46 result-4 -> /nix/store/dqvq26h92j1yc1vzmzprdpwmqld27iqj-adoptopenjdk-openj9-bin-11
|
This is good to go right? |
|
LGTM I assume we have tried using this in say |
NeQuissimus
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Oracle JDK 11 is not free of charge (except for development, testing, prototyping, or demonstration), and free users are guided to use OpenJDK 11.
openjdk11package is in progress, but not building yet (#47375 (comment)).This PR add binary packages of AdoptOpenJDK, which includes combinations of JDK/JRE and Hotspot/OpenJ9 variants.
Only
x86_64-linuxis supported for now, though AdoptOpenJDK itself supports many platforms and architectures.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)