Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/prometheus-exporters: add tests for new Tor exporter #48336

Merged
merged 1 commit into from Oct 15, 2018
Merged

tests/prometheus-exporters: add tests for new Tor exporter #48336

merged 1 commit into from Oct 15, 2018

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 13, 2018

This new exporter was added in #48307.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@thoughtpolice
Copy link
Member

@GrahamcOfBorg test prometheus-exporters

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.prometheus-exporters

Partial log (click to expand)

varnish# [   26.443343] ACPI: Preparing to enter system sleep state S5
varnish# [   26.446107] reboot: Power down
vde_switch: EOF data port: Interrupted system call
collecting coverage data
syncing
13 out of 13 tests succeeded
test script finished in 310.48s
vde_switch: EOF on stdin, cleaning up and exiting
cleaning up
/nix/store/izv5dijwwihd4z97c4q25dk3g2i96p3b-vm-test-run-prometheus-exporters

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.prometheus-exporters

Partial log (click to expand)

varnish# [   28.530566] systemd-shutdown[1]: Detaching DM devices.
varnish# [   28.541256] reboot: Power down
vde_switch: EOF data port: Interrupted system call
collecting coverage data
syncing
13 out of 13 tests succeeded
test script finished in 364.48s
vde_switch: EOF on stdin, cleaning up and exiting
cleaning up
/nix/store/3ghcdnwqaxk0fmi3jcisahnmd38axcxp-vm-test-run-prometheus-exporters

@thoughtpolice thoughtpolice merged commit 01d1f77 into NixOS:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @thoughtpolice @GrahamcOfBorg