New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sil-fonts: added charis, doulos, and andika #48348
Conversation
Hi! Thanks for this contribution! Your (non-long) descriptions are too long, generally. (The long descriptions are fine).
Andika's description would be fine after removing its name from it. Doulos' description isn't far from being short enough, Charis' is definitely too long. You will need to add yourself to Charis doesn't build here:
The other two are fine. For anyone wondering why Andika isn't suffixed with @f--t, If you have any questions, please ask. With those nitpicks taken care of I think this can be merged. |
d1133de
to
870a998
Compare
@samueldr Thank you for the feedback! |
Almost all good! It builds fine locally. Only one thing left from my original comment:
From the nixpkgs manual, Standard meta-attributes
As there is no entry for After you add yourself, may ask of you to squash your commits? I missed that all the fonts were added in one commit. Not a big deal, and we can live with that, but in the future it is preferred to have one commit per package. |
Thanks for bringing me up to speed with the contributions guidelines. I could separate the commits if that's needed; otherwise, I think that should be it. |
Ah, thanks! Merging it as such even if a bit out of the ordinary with regards to the commits structure. I'm sure next contribution they'll be just fine :). Thanks again for the contribution! |
Motivation for this change
added popular some popular Latin fonts from the SIL project.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)