add new eval checker for the package list with allowAliases = false #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c6f434c
reviewed
Oct 14, 2018
ofborg/src/tasks/massrebuilder.rs
Outdated
| @@ -331,6 +331,19 @@ impl<E: stats::SysEvents + 'static> worker::SimpleWorker for MassRebuildWorker<E | |||
| self.nix.clone() | |||
| ), | |||
|
|
|||
| EvalChecker::new( | |||
| "package-list-no-aliases)", | |||
There was a problem hiding this comment.
Looks like parenthesis mismatch.
closes NixOS#248 By checking the package list without aliases, we can make it more likely that people do not introduce new aliases into `nixpkgs` without removing them from the repository. Aliases are supposed to be for backward compatibility. Also, we can make sure this configuration option continues to work for people. Noteably, this configuration option is used by r-ryantm/nixpkgs-update to avoid submitting duplicate pull requests for the package and its alias, and to use the correct (non-alaised) name in the pull request.
|
@7c6f434c fixed! Thanks for reviewing. |
7c6f434c
approved these changes
Oct 14, 2018
|
@grahamc Do you think this would be ok in terms of resource usage, given that it adds an extra evaluation to each merge event? |
|
I think yes, let's see how it goes. We can change the architecture of this process if we need to. This is something we should check, since it prevents problems from reaching Hydra. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #248
By checking the package list without aliases, we can make it more
likely that people do not introduce new aliases into
nixpkgswithoutremoving them from the repository. Aliases are supposed to be for
backward compatibility.
Also, we can make sure this configuration option continues to work for
people. Noteably, this configuration option is used by
r-ryantm/nixpkgs-update to avoid submitting duplicate pull requests
for the package and its alias, and to use the correct (non-alaised)
name in the pull request.