Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan-{headers,loader}: lock revs, update sha256 after bump #48329

Merged
merged 2 commits into from Oct 13, 2018
Merged

vulkan-{headers,loader}: lock revs, update sha256 after bump #48329

merged 2 commits into from Oct 13, 2018

Conversation

lukateras
Copy link
Member

Motivation for this change

See: https://git.io/fxRIA

cc @ikervagyok @Ralith

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lukateras lukateras mentioned this pull request Oct 13, 2018
Merged
Ralith
Ralith approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! It's a shame that we can't trivially ensure src matches version but that's upstream's fault.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vulkan-headers, vulkan-loader

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vulkan-headers, vulkan-loader

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/wsm764a94ka8dzx8snp39zn47idmf9ph-vulkan-loader-1.1.85/lib
patching script interpreter paths in /nix/store/wsm764a94ka8dzx8snp39zn47idmf9ph-vulkan-loader-1.1.85
checking for references to /build in /nix/store/wsm764a94ka8dzx8snp39zn47idmf9ph-vulkan-loader-1.1.85...
shrinking RPATHs of ELF executables and libraries in /nix/store/6hi36f5fs65zjgzh70qpw23s6gradjrf-vulkan-loader-1.1.85-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6hi36f5fs65zjgzh70qpw23s6gradjrf-vulkan-loader-1.1.85-dev/lib
patching script interpreter paths in /nix/store/6hi36f5fs65zjgzh70qpw23s6gradjrf-vulkan-loader-1.1.85-dev
checking for references to /build in /nix/store/6hi36f5fs65zjgzh70qpw23s6gradjrf-vulkan-loader-1.1.85-dev...
/nix/store/ym5bkj9xmd322vjalllfhxibc5bvkhsl-vulkan-headers-1.1.85
/nix/store/wsm764a94ka8dzx8snp39zn47idmf9ph-vulkan-loader-1.1.85

@lukateras lukateras merged commit ea6fc49 into NixOS:master Oct 13, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vulkan-headers, vulkan-loader

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/pqlr5xlm1dnn2vhngnpy2wg3ilhg3xyd-vulkan-loader-1.1.85/lib
patching script interpreter paths in /nix/store/pqlr5xlm1dnn2vhngnpy2wg3ilhg3xyd-vulkan-loader-1.1.85
checking for references to /build in /nix/store/pqlr5xlm1dnn2vhngnpy2wg3ilhg3xyd-vulkan-loader-1.1.85...
shrinking RPATHs of ELF executables and libraries in /nix/store/95ib00ssi9frhrl7p2sijjmsfd9nk4ly-vulkan-loader-1.1.85-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/95ib00ssi9frhrl7p2sijjmsfd9nk4ly-vulkan-loader-1.1.85-dev/lib
patching script interpreter paths in /nix/store/95ib00ssi9frhrl7p2sijjmsfd9nk4ly-vulkan-loader-1.1.85-dev
checking for references to /build in /nix/store/95ib00ssi9frhrl7p2sijjmsfd9nk4ly-vulkan-loader-1.1.85-dev...
/nix/store/82b2k5ij7y6pibibb5gjgmn760bj30lp-vulkan-headers-1.1.85
/nix/store/pqlr5xlm1dnn2vhngnpy2wg3ilhg3xyd-vulkan-loader-1.1.85

@ikervagyok
Copy link
Contributor

thanks and sorry ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @GrahamcOfBorg @ikervagyok @Ralith