Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-solc: init at 3.2.0 #48323

Closed
wants to merge 2 commits into from
Closed

py-solc: init at 3.2.0 #48323

wants to merge 2 commits into from

Conversation

paulperegud
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

@GrahamcOfBorg build python3Packages.py-solc

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.py-solc

Partial log (click to expand)

warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'py_solc.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/m84mirh8yas0d8s9sw3ih6jlbk0a0a72-python3.6-py-solc-3.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.py-solc

Partial log (click to expand)

warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'py_solc.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/hrj02gyp0pabwxg8zxhx79xqd9h1pgdg-python3.6-py-solc-3.2.0

@FRidh
Copy link
Member

FRidh commented Oct 13, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.py-solc

Partial log (click to expand)

warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'py_solc.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/g1jwf2fldbcsbrl3358aclqa6l26q4v3-python3.6-py-solc-3.2.0

@paulperegud
Copy link
Author

@FRidh Disabling tests for now, since I can't get them running. Created an issue for that: ethereum/py-solc#60

@ryantm ryantm assigned ryantm and unassigned ryantm Apr 6, 2019
JohnAZoidberg
JohnAZoidberg reviewed Apr 29, 2019
View reviewed changes
pkgs/development/python-modules/py-solc/default.nix

meta = with lib; {
description = "Python wrapper around the solc binary";
license = licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add homepage = "https://github.com/ethereum/py-solc";

@JohnAZoidberg
Copy link
Member

Looks like they're not maintaining it anymore: ethereum/py-solc#65 (comment)
Doesn't even support the newest version of solc.

But he created a fork. Maybe you'd want to package that instead.

@paulperegud
Copy link
Author

I will not need this one anymore.

@paulperegud paulperegud closed this May 7, 2019
@paulperegud paulperegud deleted the py-solc branch May 7, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paulperegud @FRidh @GrahamcOfBorg @JohnAZoidberg @ryantm @Janik-Haag