Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipenv: remove uncessary dependencies #48403

Closed
wants to merge 1 commit into from
Closed

Pipenv: remove uncessary dependencies #48403

wants to merge 1 commit into from

Conversation

patjouk
Copy link
Contributor

@patjouk patjouk commented Oct 14, 2018

Motivation for this change

invoke, parver and flake8 are not necessary to install and run pipenv. I replaced requests by certifi. @domenkozar Do you remember why you added them?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Oct 14, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See setup.py:

    setup_requires=["invoke", "parver"],

Please test with sandboxing enabled otherwise pip/setuptools will fetch dependencies from PyPI.

@FRidh
Copy link
Member

FRidh commented Oct 14, 2018

They should be added as buildInputs.

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

Any updates on this pull request, please?

@prusnak
Copy link
Member

prusnak commented Oct 27, 2019

@patjouk ping?

@FRidh
Copy link
Member

FRidh commented Oct 28, 2019

This has been taken care of in an earlier commit of mine. Closing.

@FRidh FRidh closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patjouk @FRidh @mmahut @prusnak @GrahamcOfBorg