Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.28.0.41 -> 8.32.0.44 #48391

Merged
merged 2 commits into from Oct 14, 2018
Merged

skypeforlinux: 8.28.0.41 -> 8.32.0.44 #48391

merged 2 commits into from Oct 14, 2018

Conversation

KiaraGrouwstra
Copy link
Contributor

Motivation for this change

Fixes 404 on https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.28.0.41_amd64.deb, as only more recent versions are still available, as previously noted at #31047. Avoiding x.y.76.z releases as per the comment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@KiaraGrouwstra
skypeforlinux: 8.28.0.41 -> 8.32.0.44
3dbc440 
Fixes 404 on https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.28.0.41_amd64.deb, as only [more recent versions](https://repo.skype.com/deb/pool/main/s/skypeforlinux/) are still available, as previously noted at NixOS#31047. Avoiding `x.y.76.z` releases as per the comment.
@KiaraGrouwstra KiaraGrouwstra mentioned this pull request Oct 14, 2018
Closed
@dywedir
Copy link
Member

dywedir commented Oct 14, 2018

You should also update sha256

emmanuelrosa
emmanuelrosa suggested changes Oct 14, 2018
View reviewed changes
Copy link
Contributor

@emmanuelrosa emmanuelrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the sha256 in the application of fetchurl. This change will not work as-is. The correct sha256 is 0yzh4bmv8mrfp0ml9nhcpcy0lhi8jp1fnmnxy0krvnphkp8750c7.

@KiaraGrouwstra
Copy link
Contributor Author

@dywedir @emmanuelrosa whoops, thanks! I've fixed it now.

@dywedir
Copy link
Member

dywedir commented Oct 14, 2018

Thanks!

@dywedir dywedir merged commit 72128fc into NixOS:master Oct 14, 2018
@rycee
Copy link
Member

rycee commented Oct 14, 2018

Should probably cherry-pick this to release-18.09 since the same problem most likely will manifest itself there as well.

dywedir pushed a commit that referenced this pull request Oct 14, 2018
@KiaraGrouwstra @dywedir
skypeforlinux: 8.28.0.41 -> 8.32.0.44 (#48391)
320499c 
* skypeforlinux: 8.28.0.41 -> 8.32.0.44

Fixes 404 on https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.28.0.41_amd64.deb, as only [more recent versions](https://repo.skype.com/deb/pool/main/s/skypeforlinux/) are still available, as previously noted at #31047. Avoiding `x.y.76.z` releases as per the comment.

* update sha256

(cherry picked from commit 72128fc)
@dywedir
Copy link
Member

dywedir commented Oct 14, 2018

Backported to release-18.09 in 320499c

shdpl pushed a commit to shdpl/nixpkgs that referenced this pull request Nov 12, 2018
@KiaraGrouwstra @shdpl
skypeforlinux: 8.28.0.41 -> 8.32.0.44 (NixOS#48391)
e59c9ee 
* skypeforlinux: 8.28.0.41 -> 8.32.0.44

Fixes 404 on https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.28.0.41_amd64.deb, as only [more recent versions](https://repo.skype.com/deb/pool/main/s/skypeforlinux/) are still available, as previously noted at NixOS#31047. Avoiding `x.y.76.z` releases as per the comment.

* update sha256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelrosa emmanuelrosa emmanuelrosa requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KiaraGrouwstra @dywedir @rycee @emmanuelrosa @GrahamcOfBorg